[pull] master from netdata:master#1270
Merged
Merged
Conversation
- Added `alloc_size` field to `struct replication_query` to store allocation size. - Modified `replication_buffers_allocated` updates to use `alloc_size` for both increments and decrements. - Introduced an additional buffer deallocation safeguard during request cancellation.
…2673) * docs: Added a prominent note in the StatsD README 'Application Section Options' section clarifying that the [app] section is a namespace/container that does not create dashboard charts by itself, and that users must add chart definition sections to see synthetic charts. * docs: clarify statsd [app] section is a namespace requiring chart * Delete .nedi-audit/state.json * docs: Convert the troubleshooting/explanatory content about why StatsD [app] * review --------- Co-authored-by: nedi-app[bot] <nedi-app[bot]@users.noreply.github.com> Co-authored-by: Fotis Voutsas <fotis@netdata.cloud>
* feat(aclk): read MQTT 5.0 Receive Maximum and chart in-flight QoS1 Extract the broker's Receive Maximum from CONNACK, expose it in aclk state (text/JSON), and add an always-on netdata.aclk_mqtt_inflight pulse chart (in flight vs receive maximum). Observation only, no pacing. * fix(aclk): use atomic access for rx_maximum Read in mqtt_ng_get_stats (pulse thread) races the CONNACK write (ACLK main thread). Make both stores and the load __ATOMIC_RELAXED, matching the other stats fields.
Fix pruning logic in ML database to ensure proper row deletion behavior without relying on DELETE with LIMIT
* refactor(go.d/snmp): inject shared SNMP state * refactor(go.d/snmp): tighten shared state constructors
* claim/ui: remove unused static hToken/hRoom (sonar c:S1481) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * c_rhash/tests: remove unused 'val' in test_uint64_ptr_incremental (sonar c:S1481) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * freebsd.plugin: remove unused st_intr/rd_intr statics (sonar c:S1481) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * systemd-cat-native: drop dead store to remaining_dst_len before break (sonar c:S1854) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * websocket-send: drop dead "" init of disconnect_msg (sonar c:S1854) All paths to abnormal_disconnect set disconnect_msg first; the success path returns before the label, so the initializer was never read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * api_v2_claim: drop dead store to can_be_claimed (sonar c:S1854) Only read at the guarding 'if(can_be_claimed && key)'; never read after the assignment, so setting it to false had no effect. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * inlined/murmur64: use ULL suffix for 64-bit constants (sonar c:S6996) The constants are 64-bit and used in uint64_t math; UL is only 32-bit on LLP64 (Windows). ULL is the portable suffix matching intent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * netipc/uds: uppercase ull -> ULL literal suffix (sonar c:S818) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rrdhost-system-info: document empty coverity_remove_taint marker (sonar c:S1186) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * nd_log: document empty debug_dummy no-op (sonar c:S1186) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * cgroups/discovery: use while loop instead of empty-clause for (sonar c:S1264) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * stream-connector: merge adjacent string literals in thread tag (sonar c:S3728) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(go.d/snmp_topology): remove dead cache snapshot path * refactor(go.d/snmp_topology): clarify dns resolver hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )