[pull] master from netdata:master#1271
Merged
Merged
Conversation
refactor(go.d/snmp-topology): extract topology Function package
#22771) fix(journal-log-writer): reject non-absolute journal directory at startup A relative journal_dir was accepted through Log::new init (the discarded canonicalize result left the path relative), then failed at first write with a cause-less "failed to create journal file in <path>" because repository::File::from_path only accepts absolute paths. To OTLP clients this surfaced as a permanent "Failed to write log entry" gRPC Internal error and dropped log batches. Validate that the journal directory is absolute as the first step of create_chain, before any I/O, returning an InvalidPath error that names the offending value, and enrich the residual create-file error to describe the real remaining failure mode (unparseable generated file path). Relative-path resolution stays the consumer's responsibility: netflow resolves its relative default against the netdata cache dir when one is available, and the new Log::new check is the safety net for the standalone case. Add tests and a directory-contract spec; note the requirement in the stock otel config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )