WTEL-8487: Restrict has_file filter to call recordings in calls history - #454
Open
vlad-marusyk-wt wants to merge 1 commit into
Open
WTEL-8487: Restrict has_file filter to call recordings in calls history#454vlad-marusyk-wt wants to merge 1 commit into
vlad-marusyk-wt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
Фільтр "Запис розмови" у розділі History (has_file=true в /api/calls/history) повертав дзвінки з будь-яким прикріпленим файлом: скріншотами, записами екрана оператора тощо. Причина в тому, що умова в SQL перевіряла лише наявність колонки files (files notnull), а view cc_calls_history_list агрегує в неї всі файли зі storage.files за uuid дзвінка без фільтра за типом.
Вирішення
Умова has_file замінена на прямий exists до storage.files з критерієм "запис розмови": не видалений, з каналом call (або NULL для легасі-записів, створених до появи колонки channel) та mime-типом audio/* або video/. Це відсікає скріншоти (зокрема збережені з каналом call, але з image/), записи екрана оператора (screenrecording) та інші.