Skip to content

chore: WPB-26770 Update welcome and help message content - #81

Merged
bbaarriiss merged 2 commits into
mainfrom
chore/WPB-26770-update-welcome-and-help-message
Jul 7, 2026
Merged

chore: WPB-26770 Update welcome and help message content#81
bbaarriiss merged 2 commits into
mainfrom
chore/WPB-26770-update-welcome-and-help-message

Conversation

@bbaarriiss

Copy link
Copy Markdown

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to update the content of the welcome and help message to a version which is more clear and helpful to the users.

Solutions

Update the content of the welcome and help message based on the team aggreement.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

How to Test

  • Run the app in your local.
  • Add the app in a conversation and verify the welcome message.
  • Type '/poll help'
  • Verify the help message
  • Use the example command and verify that poll is created successfully.

@bbaarriiss bbaarriiss self-assigned this Jul 6, 2026
@bbaarriiss
bbaarriiss requested a review from a team as a code owner July 6, 2026 15:36
@claude

claude Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review: chore: WPB-26770 Update welcome and help message content

Thanks for the update — the new copy is clearer and more welcoming, and the concrete /poll help example in USAGE is a nice touch. The change is well-scoped (single file, content-only). I verified the example command /poll "What do you want for lunch?" "Pizza" "Sushi" "Burgers" parses correctly against InputParser (straight " quotes are supported delimiters), so the "How to Test" flow works as described.

A few small suggestions:

1. Inconsistent apostrophe characters (minor)

UserCommunicationService.kt:31 uses a curly/typographic apostrophe:

"Here’s how it works:\n" +   // U+2019

while the rest of the file uses ASCII apostrophes ("I'm the Poll app..."). Recommend standardizing on ASCII ' for consistency and to avoid encoding surprises across clients.

2. Inconsistent bullet punctuation (nit)

Only one of the three bullets ends with a period:

🗳️ Your votes are always anonymous
📊 People can view the current vote count at any time.   <-- trailing period
🔍 Get a reminder how to start a poll by entering /poll help

Consider making the three lines punctuation-consistent (all with or all without trailing periods).

3. USAGE no longer references /poll help (UX consideration)

The old USAGE string ended with To display usage write /poll help. That hint is now gone from USAGE, which is still appended to both fallback messages:

FallbackMessageType.WRONG_COMMAND -> "I couldn't recognize your command. $USAGE"
FallbackMessageType.MISSING_DATA  -> "No data for poll. Please create a new one. $USAGE"

The welcome message still mentions /poll help, but a user who hits an error later won't be reminded that help exists. Since USAGE now shows a full working example this is probably acceptable — just flagging that the "how to get help" affordance disappears from the error paths.

Tests

No test changes are needed — UserCommunicationServiceTest and MessagesHandlingServiceTest don't assert on message contents, so nothing breaks. That said, since these strings are now user-facing product copy, a lightweight assertion (e.g. that WELCOME_MESSAGE contains the /poll help hint and a valid example) could guard against accidental regressions in future edits.

Overall this looks good to merge once the apostrophe/punctuation nits are addressed. 👍

* Use same apostrophes for both case.
@bbaarriiss
bbaarriiss merged commit eac5fd2 into main Jul 7, 2026
4 checks passed
@bbaarriiss
bbaarriiss deleted the chore/WPB-26770-update-welcome-and-help-message branch July 7, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants