You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review: chore: WPB-26770 Update welcome and help message content
Thanks for the update — the new copy is clearer and more welcoming, and the concrete /poll help example in USAGE is a nice touch. The change is well-scoped (single file, content-only). I verified the example command /poll "What do you want for lunch?" "Pizza" "Sushi" "Burgers" parses correctly against InputParser (straight " quotes are supported delimiters), so the "How to Test" flow works as described.
A few small suggestions:
1. Inconsistent apostrophe characters (minor)
UserCommunicationService.kt:31 uses a curly/typographic apostrophe:
"Here’s how it works:\n" + // U+2019
while the rest of the file uses ASCII apostrophes ("I'm the Poll app..."). Recommend standardizing on ASCII ' for consistency and to avoid encoding surprises across clients.
2. Inconsistent bullet punctuation (nit)
Only one of the three bullets ends with a period:
🗳️ Your votes are always anonymous
📊 People can view the current vote count at any time. <-- trailing period
🔍 Get a reminder how to start a poll by entering /poll help
Consider making the three lines punctuation-consistent (all with or all without trailing periods).
3. USAGE no longer references /poll help (UX consideration)
The old USAGE string ended with To display usage write /poll help. That hint is now gone from USAGE, which is still appended to both fallback messages:
FallbackMessageType.WRONG_COMMAND -> "I couldn't recognize your command. $USAGE"
FallbackMessageType.MISSING_DATA -> "No data for poll. Please create a new one. $USAGE"
The welcome message still mentions /poll help, but a user who hits an error later won't be reminded that help exists. Since USAGE now shows a full working example this is probably acceptable — just flagging that the "how to get help" affordance disappears from the error paths.
Tests
No test changes are needed — UserCommunicationServiceTest and MessagesHandlingServiceTest don't assert on message contents, so nothing breaks. That said, since these strings are now user-facing product copy, a lightweight assertion (e.g. that WELCOME_MESSAGE contains the /poll help hint and a valid example) could guard against accidental regressions in future edits.
Overall this looks good to merge once the apostrophe/punctuation nits are addressed. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We need to update the content of the welcome and help message to a version which is more clear and helpful to the users.
Solutions
Update the content of the welcome and help message based on the team aggreement.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
How to Test