Skip to content

chore: Update prod helm to sha containing remove percentage#86

Merged
spoonman01 merged 1 commit into
mainfrom
chore/prod-helm-no-percentages
Jul 20, 2026
Merged

chore: Update prod helm to sha containing remove percentage#86
spoonman01 merged 1 commit into
mainfrom
chore/prod-helm-no-percentages

Conversation

@spoonman01

Copy link
Copy Markdown

No description provided.

@spoonman01
spoonman01 requested a review from a team as a code owner July 20, 2026 09:43
@spoonman01 spoonman01 self-assigned this Jul 20, 2026
@claude

claude Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review — chore: Update prod helm to sha containing remove percentage

Summary: Single-line bump of the prod image tag in helm/pollapp/values-prod.yaml from sha-9a03ad7 to sha-5c7f84a. Scope is appropriately small and matches the PR title/intent.

What is good

  • Immutable SHA pinning. Pinning to a sha-* tag (rather than a mutable tag like latest, which values.yaml uses for the default) is the right call for prod — reproducible, auditable deploys.
  • Change is isolated to the prod values override; no unrelated edits.

Worth confirming before merge

  • Verify the target image exists and was tested. The commit 5c7f84a is not reachable from this repo checkout, so I could not confirm from here that quay.io/wire/poll-app:sha-5c7f84a was actually built/pushed and contains the intended "remove percentage" change. Please double-check the image is present in Quay and passed CI before this rolls to prod.
  • Traceability. This PR has no description — consider adding a one-line note linking the source PR/commit that removed the percentage. Makes the prod rollout easier to audit and roll back later.

Minor / out of scope

  • The file header notes this config should eventually move to the argocd-integrations repo. Not this PR job, but this manual tag-bump toil is exactly what ArgoCD image automation would remove — worth prioritizing that migration.

Other dimensions

  • Bugs / performance / security: none introduced — config value change only, no code, secrets, or resource impact.
  • Tests: N/A for a Helm value bump.

Overall this looks fine to merge once the target image is confirmed built and validated.

@spoonman01
spoonman01 merged commit 28b4dae into main Jul 20, 2026
5 checks passed
@spoonman01
spoonman01 deleted the chore/prod-helm-no-percentages branch July 20, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants