Harden production runtime, installer, and release trust boundaries - #134
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge method required
Use Create a merge commit. Do not squash or rebase this PR.
The reusable workflow callers intentionally pin immutable implementation commit
0440f3d3a42216a23ce455686ce983b88af62a3e. Squashing would omit that commit and rebasing would rewrite it, breaking reusable-workflow resolution, runner-group selection, trusted-tool checkout, and the documented OIDC identity.After merge, verify the implementation commit is reachable before updating privileged infrastructure:
During that maintenance window, keep SDK integration disabled/fail-closed and do not start a release. Change the
wiresock-sdkrunner group's sole selected workflow and the Azure federated credential'sjob_workflow_reffrom the previous pin to0440f3d3a42216a23ce455686ce983b88af62a3e, then re-enable privileged execution only after the hosted policy preflight passes.Summary
WindowsPrincipal.IsInRoleVersionNTgating with an exactCurrentBuildNumberAppSearch contractValidation
/W4 /WX; static x86, x64, and ARM64 host validation; exact self-test/token contract checkspublish --no-buildisolation regression; validated production x86 launcherdotnet format --verify-no-changes, andgit diff --checkLocal limitations: Windows symlink creation was unavailable for one managed fixture. Live elevated native-host and install/repair/uninstall behavior remains covered by guarded CI runners. NuGet vulnerability metadata was unavailable from the local sandbox, while locked restores and CI audit enforcement remain configured.