Support homeId in me response - #331
Merged
wmalgadey merged 1 commit intoJun 28, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 76.16% 76.11% -0.05%
==========================================
Files 37 37
Lines 2207 2211 +4
Branches 134 136 +2
==========================================
+ Hits 1681 1683 +2
- Misses 485 486 +1
- Partials 41 42 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Tado accounts now return a
homeIdfield from themeendpoint instead of ahomesarray. In that case device activation fails while_get_idindexesresponse["homes"], which blocks Home Assistant's Tado config flow.This keeps the existing
homes[0].idpath and adds ahomeIdfallback before raising a clearTadoExceptionfor unexpected responses.Related Home Assistant issue: home-assistant/core#165689
Validation:
python -m pytest tests\test_http.py -qpython -m pytest -qpython -m ruff check PyTado\http.py --line-length=100python -m flake8 PyTado\http.py --max-line-length=100python -m black --check PyTado\http.py tests\test_http.pypython -m bandit -c pyproject.toml PyTado\http.pyNote:
python -m mypy PyTado testsstill reports existing repository-wide typing issues, including missing requests stubs and unannotated test functions; the new code path did not add errors inPyTado/http.py.