Make the random generator of _Rsa and RsaPublic configurable.#93
Merged
Merged
Conversation
Member
|
Okay to test. Contributor agreement on file. |
dgarske
previously approved these changes
Apr 8, 2026
Member
|
@roberthdevries please resolve the merge conflict. Thanks! Awesome work on these cleanups. |
roberthdevries
force-pushed
the
rsa-public-add-rng-param
branch
from
April 9, 2026 17:42
3f5fd16 to
193d327
Compare
Contributor
Author
|
Merge conflict is now resolved. |
dgarske
approved these changes
Apr 9, 2026
dgarske
requested changes
Apr 9, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: REQUEST_CHANGES
Findings: 3 total — 3 posted, 1 skipped
Posted findings
- [High] Mutable default argument
rng=Random()in_Rsa.__init__—wolfcrypt/ciphers.py:653 - [Medium]
RsaPrivate.__init__not updated to accept/forwardrngparameter —wolfcrypt/ciphers.py:849-851 - [Medium] No tests for the new
rngparameter —tests/test_ciphers.py
Skipped findings
- [Medium] No tests for the new
rngparameter
Review generated by Skoll via openclaw
roberthdevries
force-pushed
the
rsa-public-add-rng-param
branch
from
April 11, 2026 15:56
193d327 to
6279edc
Compare
dgarske
requested review from
JeremiahM37,
dgarske and
sebastian-carpenter
and removed request for
sebastian-carpenter
April 14, 2026 22:20
JeremiahM37
previously approved these changes
Apr 15, 2026
dgarske
reviewed
Apr 15, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 2 total — 2 posted, 1 skipped
Posted findings
- [Medium]
from_pemfactory methods don't accept or forwardrngparameter —wolfcrypt/ciphers.py:719,878 - [Medium] No tests for the new
rngparameter —tests/test_ciphers.py:329-374
Skipped findings
- [Medium]
from_pemfactory methods don't accept or forwardrngparameter
Review generated by Skoll via openclaw
roberthdevries
force-pushed
the
rsa-public-add-rng-param
branch
from
April 16, 2026 20:46
6279edc to
5b12533
Compare
Contributor
Author
|
|
dgarske
self-requested a review
April 16, 2026 20:57
dgarske
approved these changes
Apr 16, 2026
JeremiahM37
approved these changes
Apr 17, 2026
roberthdevries
force-pushed
the
rsa-public-add-rng-param
branch
from
April 17, 2026 18:19
5b12533 to
186cded
Compare
This was the only class that has hardcoded the random number generator in the implementation.
roberthdevries
force-pushed
the
rsa-public-add-rng-param
branch
from
April 17, 2026 21:19
186cded to
377542f
Compare
dgarske
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the only class that has hardcoded the random number generator in the implementation.