docs: record the META-236 vendor-notice change, and fix stale paths - #8
Merged
Merged
Conversation
META-247's ruling required the vendor-notice change to carry "its own evidence AND announcement". The evidence landed — parity receipt, a recorded entry in migration/parity-expected-differences.txt, a separate commit — but the announcement did not. agents-audit's [Unreleased] section had the two META-157 items and nothing for META-236. Added to packages/agents-audit-compat/CHANGELOG.md: - the `scan` output change, stating plainly that exit codes are unchanged and `scan --json` is byte-identical, so machine-readable consumers are unaffected; - the added `renderMissingArtifactNotice` export, and that `renderVrekoUpsell` remains exported and unchanged — additive, nothing removed. Four stale references found while sweeping for others. One was a real break: 1. scripts/verify-published.mjs read ../packages/agents-audit/package.json for the release version. That path stopped existing in META-247, so the script threw on startup. It is only invoked from the disabled release path, so it was latent — but it would have failed the META-243 cutover at exactly the wrong moment. Repointed; it now runs, installs agents-audit@0.4.4 from the registry and verifies the binary. 2. .gitignore ignored packages/agents-audit/.tmp-*/ — the producer conformance tests that create those directories moved to packages/cli, so their temp dirs were no longer ignored and could have been committed. Generalised to packages/*/.tmp-*/. 3. .github/pull_request_template.md pointed contributors at packages/agents-audit/dist/cli.js. Repointed, and the parity harness added to the checklist for changes to anything agents-audit exposes. 4. Red-test fixture paths in check-architecture.test.mjs named a package that no longer exists. Functionally harmless — they write into a scratch copy — but they should read as the current layout. Also: packages/cli declared CHANGELOG.md in its `files` list but had no such file, so the packed tarball silently shipped without the changelog it claims. Added one, stating up front that the package has never been published and must not be documented as installable until META-243. The root CHANGELOG linked to ./packages/agents-audit/CHANGELOG.md — a dead link since META-247 — and had no repository-level entry for the architecture change at all. Both fixed. Verification typecheck 3/3 · build 3/3 · tests 82 (32 + 44 + 6) architecture guard pass · red tests 19/19 release:verify-packs pass · release:verify-published now runs (was throwing) parity: runtime, pack and shim all exit 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
META-247's ruling required the vendor-notice change to carry "its own evidence and announcement." The evidence landed — parity receipt, a recorded entry in
migration/parity-expected-differences.txt, a separate commit. The announcement did not:agents-audit's[Unreleased]section had the two META-157 items and nothing for META-236.The announcement
Two entries added to
packages/agents-audit-compat/CHANGELOG.md:scanoutput change, stating plainly that exit codes are unchanged andscan --jsonis byte-identical, so nothing consuming machine-readable output is affected;renderMissingArtifactNoticeexport, and thatrenderVrekoUpsellremains exported and unchanged — additive, nothing removed.Four stale references found while sweeping. One was a real break.
1.
scripts/verify-published.mjswas throwing on startup. It read../packages/agents-audit/package.jsonfor the release version — a path that stopped existing in META-247:It is only invoked from the disabled release path, so it was latent — but it would have failed the META-243 cutover, at exactly the wrong moment. Repointed; it now runs, installs
agents-audit@0.4.4from the registry and verifies the binary.2.
.gitignorewas ignoring the wrong directory. It ignoredpackages/agents-audit/.tmp-*/, but the producer conformance tests that create those directories moved topackages/cli— so their temp dirs were no longer ignored and could have been committed. Generalised topackages/*/.tmp-*/.3.
.github/pull_request_template.mdpointed contributors atpackages/agents-audit/dist/cli.js. Repointed, and the parity harness added to the checklist for changes to anythingagents-auditexposes.4. Red-test fixture paths in
check-architecture.test.mjsnamed a package that no longer exists. Functionally harmless — they write into a scratch copy — but they should read as the current layout.Two changelog defects
packages/clideclaredCHANGELOG.mdin itsfileslist but had no such file, so the packed tarball silently shipped without the changelog it claims to include. Added one, stating up front that the package has never been published and must not be documented as installable until META-243.The root
CHANGELOG.mdlinked to./packages/agents-audit/CHANGELOG.md— a dead link since META-247 — and had no repository-level entry for the architecture change at all. Both fixed, with entries for META-244, META-247 and the parity gating.Verification
Scope
Documentation and path corrections. No package, producer, guard or parity behavior changed; no parity assertion weakened.