feat: add imagePullSecret reference configuration option#202
Open
schaer-bgs wants to merge 1 commit into
Open
Conversation
kavindasr
requested changes
Jun 12, 2026
kavindasr
left a comment
kavindasr
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution. I have added a few comments. The same applies to the other components as well.
| {{- end }} | ||
| {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} | ||
| imagePullSecrets: | ||
| {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} |
| # Specify image pull secrets for private registries | ||
| imagePullSecrets: | ||
| enabled: false | ||
| name: "" |
| | wso2.deployment.image.digest | string | `""` | Docker image digest | | ||
| | wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) | | ||
| | wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | | ||
| | wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,name:"","password":"","username":""}` | Container registry credentials. Specify image pull secrets or a reference to secret for private registries | |
Contributor
There was a problem hiding this comment.
Use helm-docs command to generate docs
| {{- end }} | ||
| {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} | ||
| imagePullSecrets: | ||
| {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} |
Contributor
|
@schaer-bgs Also, please include the test results from running PS: |
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently imagePullSecret requires a username/password in the values.yaml and does not allow to reference custom (encrypted) secrets.
Goals
Add a
imagePullSecret.nameproperty which allows to reference custom secrets while keeping backwards compatability.Approach
Adds conditionals to either set the imagePullSecret name or use the prior assembled/generated secret.