Make schema.sql self-migrating for forwarded_for column#6
Open
yellowman wants to merge 1 commit into
Open
Conversation
CREATE TABLE IF NOT EXISTS is a no-op on databases that already have a submissions table, so the forwarded_for column would never appear on an existing install. Add an idempotent ALTER TABLE ... ADD COLUMN IF NOT EXISTS so re-running schema.sql migrates older databases; it is a no-op on fresh installs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EtMfJEmMXbwnUJ9p3uFXXN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE TABLE IF NOT EXISTS is a no-op on databases that already have a submissions table, so the forwarded_for column would never appear on an existing install. Add an idempotent ALTER TABLE ... ADD COLUMN IF NOT EXISTS so re-running schema.sql migrates older databases; it is a no-op on fresh installs.
Claude-Session: https://claude.ai/code/session_01EtMfJEmMXbwnUJ9p3uFXXN
Note
Low Risk
Single additive, idempotent DDL line with no application logic changes.
Overview
schema.sqlcan now upgrade older databases that already had asubmissionstable but were created beforeforwarded_forexisted.Because
CREATE TABLE IF NOT EXISTSdoes nothing on existing tables, those installs would never pick up the column from the table definition alone. This change adds an idempotentALTER TABLE submissions ADD COLUMN IF NOT EXISTS forwarded_for TEXTplus a short comment that re-running the script is the intended migration path. Fresh installs are unchanged (the column is already inCREATE TABLE; theALTERis a no-op).Reviewed by Cursor Bugbot for commit 37acf7a. Bugbot is set up for automated code reviews on this repo. Configure here.