perf/cleanup(stark): tidy LogUp accumulated column + absorbed-1 const…#686
Open
diegokingston wants to merge 3 commits into
Open
perf/cleanup(stark): tidy LogUp accumulated column + absorbed-1 const…#686diegokingston wants to merge 3 commits into
diegokingston wants to merge 3 commits into
Conversation
…raint lookup.rs, three byte-identical improvements: - build_accumulated_column_from_terms: invert N in the BASE field (a base inversion vs a cubic-extension inversion) and multiply base x extension with the base operand on the left. Cleaner; trivial (once per table). - build_accumulated_column_from_terms: cache each row's column-sum in a single pass and reuse it for the accumulated column, instead of summing every term column twice (drops one full pass over all term columns during trace build). - LookupAccumulatedConstraint, absorbed.len()==1 arm: conditionally negate the multiplicity in the base field (signed_m + delta*f) instead of an E x E sign multiply that also promotes m base->ext. Removes a per-row extension multiply in the hot constraint-eval / composition-poly path, matching the 2-interaction arm. Identical value: delta*f - m (sender) / delta*f + m (receiver). stark lib 128/128 (prove+verify; covers absorbed.len()==1 and ==2 arms).
Collaborator
Author
|
/bench 5 |
Benchmark — fib_iterative_8M (median of 5)Table parallelism: auto (cores / 3)
Commit: fb187cf · Baseline: cached · Runner: self-hosted bench |
Collaborator
Author
|
/bench 5 |
compute_deep_composition_poly_evaluations: in the per-row H-terms loop the denominator inverse inv_h[i] is constant across composition-poly parts, but it was multiplied in once per part. Sum the parts first (Σⱼ γⱼ·(Hⱼ-Hⱼ(z))) and multiply by inv_h[i] once. Distributivity makes it exact → byte-identical proof; saves (num_parts-1) extension mults per row over the whole LDE. The trace-terms loop just below already does sum-then-multiply-once.
Collaborator
Author
|
/bench 5 |
1 similar comment
Collaborator
Author
|
/bench 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…raint
lookup.rs, three byte-identical improvements:
stark lib 128/128 (prove+verify; covers absorbed.len()==1 and ==2 arms).