refactor(ecsm): move inlined tests + reference arithmetic into src/te…#687
Open
diegokingston wants to merge 1 commit into
Open
refactor(ecsm): move inlined tests + reference arithmetic into src/te…#687diegokingston wants to merge 1 commit into
diegokingston wants to merge 1 commit into
Conversation
…sts/
The three source files mixed production code with test-only code. Relocate it all
into a dedicated src/tests/ tree (matching the stark/prover convention:
`#[cfg(test)] mod tests;` + tests/mod.rs), leaving lib.rs/curve.rs/witness.rs as
pure production:
- tests/lib_tests.rs <- lib.rs's inlined `mod tests`
- tests/curve_tests.rs <- curve.rs's `mod parity_tests`
- tests/witness_tests.rs <- witness.rs's inlined `mod tests`
- tests/reference.rs <- curve.rs's #[cfg(test)] reference impl
(point_double / point_add / step_lambda /
replay_double_and_add_reference)
- tests/reference_field.rs <- the whole #[cfg(test)] field.rs (BigUint Fp)
- field.rs deleted
Test helpers' hex-parse .unwrap() -> .expect(...) for clearer panics. Fixed a
now-dangling intra-doc link in replay_double_and_add. Behavior-preserving:
ecsm lib 15/15, clippy clean, production builds with no test deps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sts/
The three source files mixed production code with test-only code. Relocate it all into a dedicated src/tests/ tree (matching the stark/prover convention:
#[cfg(test)] mod tests;+ tests/mod.rs), leaving lib.rs/curve.rs/witness.rs as pure production:mod testsmod parity_testsmod tests(point_double / point_add / step_lambda /
replay_double_and_add_reference)
Test helpers' hex-parse .unwrap() -> .expect(...) for clearer panics. Fixed a now-dangling intra-doc link in replay_double_and_add. Behavior-preserving: ecsm lib 15/15, clippy clean, production builds with no test deps.