Add white paper drafting and build pipeline - #3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbecbf3903
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## One time setup | ||
| ``` | ||
| tools/scripts/zd_whitepaper_bootstrap.sh --with-tectonic |
There was a problem hiding this comment.
These new shell scripts are committed with mode 100644 (git ls-files -s shows no executable bit), but the setup/build/ship docs invoke them directly as tools/scripts/...; in a fresh clone that returns Permission denied before the shebang is used, so the documented one-time setup and build paths fail unless users manually run bash ... or chmod +x first. Mark the scripts executable or change the documented invocations consistently.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
see this is why agentic reviews are stupid. shutup codex
| red "FAIL: working tree dirty. Commit or stash first."; echo exit_code=5; exit 5 | ||
| fi | ||
| git fetch origin --quiet | ||
| git checkout -b "$BRANCH" origin/main >>"$LOG" 2>&1 || git checkout -b "$BRANCH" >>"$LOG" 2>&1 |
There was a problem hiding this comment.
If this script is rerun for the same date/slug and the local branch already exists, both git checkout -b attempts fail because -b creates a new branch (git checkout -h), but the script ignores that failure and continues on whatever branch the user was already on. In the common case of rerunning from main, the subsequent commit is made on local main while the push/PR targets the stale branch, violating the script's own "never commit to main" workflow; abort when checkout fails or choose a guaranteed-unique branch.
Useful? React with 👍 / 👎.
| PAGES=$(command -v pdfinfo >/dev/null 2>&1 && pdfinfo "$PDIR/paper.pdf" 2>/dev/null | awk '/^Pages:/{print $2}') | ||
|
|
||
| # clean working tree check, then branch | ||
| if ! git diff --quiet || ! git diff --cached --quiet; then |
There was a problem hiding this comment.
This guard only checks tracked differences, so a workspace with untracked files is still treated as clean; immediately afterward the broad git add "$PDIR" templates/whitepaper tools docs research/.gitignore can stage unrelated untracked files under docs, tools, or templates into the paper PR. Since the script advertises that it refuses dirty trees before shipping, use a status check that includes untracked files before branching/staging.
Useful? React with 👍 / 👎.
zeiddata-dev
left a comment
zeiddata-dev
left a comment
There was a problem hiding this comment.
Zeid Data admin approval via Radwuan
1 participant
Adds the research white paper pipeline: house LaTeX preamble and template under templates/whitepaper, build and bootstrap scripts under tools/scripts, the operating prompt at tools/whitepaper-agent.md, and ops docs at docs/whitepaper-pipeline.md. Fonts are vendored locally and gitignored. Infrastructure only, no paper content.