Rename rolling beta release tag to beta-fw (branch/tag collision)#91
Conversation
The rolling pre-release created a tag named "beta", colliding with the beta branch. git resolves a bare fetch refspec to refs/tags/ before refs/heads/, so ESPHome remote packages pinned to ref: beta silently fetch the tag (which pointed at main's HEAD at creation and never moves) instead of the branch tip - users following beta as a package get stale YAML no matter how often they clean caches. Rename the release tag to beta-fw and update beta_manifest_base to match. The old beta release/tag should be deleted after this merges and the renamed release is populated. Version: 26.7.8.2 (26.7.8.1 is reserved by the open Bluetooth Proxy PR #90, which will need a rebase over this) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
WalkthroughThe beta firmware release pipeline is renamed from "beta" to "beta-fw" across the GitHub Actions workflow (pre-release creation, manifest URL rewriting, artifact uploads) and the ESPHome Core config's ChangesBeta-fw release rename
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Integrations/ESPHome/Core.yaml (1)
14-14: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUpdate the stale comment on line 12 to match the renamed release.
The adjacent comment on line 12 still says
rolling "beta" pre-release assetsbut the release tag is nowbeta-fw. Similarly, line 770 saysrolling "beta" release assets. Both should referencebeta-fwto avoid confusion.♻️ Proposed fix for stale comments
# Beta = rolling "beta-fw" pre-release assets (beta branch builds). stable_manifest_base: "https://apolloautomation.github.io/MSR-1" beta_manifest_base: "https://github.com/ApolloAutomation/MSR-1/releases/download/beta-fw"And on line 770:
- # Stable = GitHub Pages, Beta = rolling "beta" release assets. + # Stable = GitHub Pages, Beta = rolling "beta-fw" release assets.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Integrations/ESPHome/Core.yaml` at line 14, The comments in Core.yaml are stale and still refer to the old “beta” release name; update the adjacent documentation comments near beta_manifest_base and the later release-assets comment so they consistently reference beta-fw. Keep the actual release URL as-is and only rename the descriptive text in the nearby comment blocks to match the current release tag and avoid confusion.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Integrations/ESPHome/Core.yaml`:
- Line 14: The comments in Core.yaml are stale and still refer to the old “beta”
release name; update the adjacent documentation comments near beta_manifest_base
and the later release-assets comment so they consistently reference beta-fw.
Keep the actual release URL as-is and only rename the descriptive text in the
nearby comment blocks to match the current release tag and avoid confusion.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 47401612-9d92-45bf-8183-4a4f576ecc02
📒 Files selected for processing (2)
.github/workflows/build-beta.ymlIntegrations/ESPHome/Core.yaml
Version: 26.7.8.2
What does this implement/fix?
The rolling pre-release created a tag named
beta, colliding with thebetabranch. git resolves a bare fetch refspec torefs/tags/beforerefs/heads/, so ESPHome remote packages pinned toref: betasilently fetch the tag - which was frozen at creation time and never moves - instead of the branch tip. Users following beta as a package get stale YAML no matter how often they clean caches.Reproduced end-to-end with an isolated cache: ESPHome's
git.pyrunsgit fetch --depth=1 -- origin betathengit reset --hard FETCH_HEAD, and.git/FETCH_HEADshowstag 'beta'being fetched. On MSR-1 the tag pointed at main's then-HEAD (e24fc3f, 26.3.2.1) while the branch tip was73fd740(26.7.7.1 with the Firmware Channel select).Fix: rename the release tag to
beta-fwand update the beta manifest URLs to match. After this merges and the renamed release is populated by the next beta build, the oldbetarelease + tag should be deleted. Until then, affected users can pinref: refs/heads/beta.Note: 26.7.8.1 is reserved by open PR #90, which will need a trivial rebase over this. Both variants config-validated on ESPHome 2026.6.4.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code
Summary by CodeRabbit