fix(connector-slack): neutral consent-card header (fits act + egress)#158
Conversation
The consent card's header was hardcoded 'peek wants to act on your browser',
which misreads for share_session's data egress (an upload, not a browser act).
The connector can't distinguish a delegated act from an egress (both use
details:{}), so make the header action-agnostic and let the summary carry the
specific request. No behavior change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: harry-harish <22562634+harry-harish@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Slack consentCard header text was changed from referencing acting on the browser to a neutral approval message ("peek wants your approval"), with added explanatory comments about delegated actions and data egress. The corresponding test assertion was tightened to exactly match the new header text. ChangesSlack Consent Card Header Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
What
The Slack consent card's header was hardcoded "peek wants to act on your browser" — which misreads for the new
share_sessiondata egress (an upload, not a browser act). Since the connector can't distinguish a delegated act from an egress (both arrive withdetails:{}), the header is made action-agnostic — "peek wants your approval" — and the summary sentence below carries the specific request (act / delegated-act / egress) in every case.blockkit.ts: header copy →peek wants your approval(+ a comment on why it's neutral).blockkit.test.ts: the delegated-path test now asserts the neutral header.No behavior change; consent gating, masking, and summary rendering are untouched. connector-slack is
private:true→ no changeset. 63 tests pass.🤖 Generated with Claude Code
Summary by CodeRabbit