Skip to content

fix(connector-slack): neutral consent-card header (fits act + egress)#158

Merged
harry-harish merged 1 commit into
mainfrom
fix/connector-consent-header
Jul 10, 2026
Merged

fix(connector-slack): neutral consent-card header (fits act + egress)#158
harry-harish merged 1 commit into
mainfrom
fix/connector-consent-header

Conversation

@harry-harish

@harry-harish harry-harish commented Jul 9, 2026

Copy link
Copy Markdown
Member

What

The Slack consent card's header was hardcoded "peek wants to act on your browser" — which misreads for the new share_session data egress (an upload, not a browser act). Since the connector can't distinguish a delegated act from an egress (both arrive with details:{}), the header is made action-agnostic — "peek wants your approval" — and the summary sentence below carries the specific request (act / delegated-act / egress) in every case.

  • blockkit.ts: header copy → peek wants your approval (+ a comment on why it's neutral).
  • blockkit.test.ts: the delegated-path test now asserts the neutral header.

No behavior change; consent gating, masking, and summary rendering are untouched. connector-slack is private:true → no changeset. 63 tests pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Slack consent card header to use clearer, approval-focused wording: “peek wants your approval.”
    • Tightened the related test to ensure the header text matches the expected message exactly.

The consent card's header was hardcoded 'peek wants to act on your browser',
which misreads for share_session's data egress (an upload, not a browser act).
The connector can't distinguish a delegated act from an egress (both use
details:{}), so make the header action-agnostic and let the summary carry the
specific request. No behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: harry-harish <22562634+harry-harish@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f5e33d24-1fd6-497e-8d7f-5caf35cf935e

📥 Commits

Reviewing files that changed from the base of the PR and between 22743c0 and db59958.

📒 Files selected for processing (2)
  • packages/connector-slack/src/blockkit.test.ts
  • packages/connector-slack/src/blockkit.ts

📝 Walkthrough

Walkthrough

The Slack consentCard header text was changed from referencing acting on the browser to a neutral approval message ("peek wants your approval"), with added explanatory comments about delegated actions and data egress. The corresponding test assertion was tightened to exactly match the new header text.

Changes

Slack Consent Card Header Update

Layer / File(s) Summary
Header text and test update
packages/connector-slack/src/blockkit.ts, packages/connector-slack/src/blockkit.test.ts
Consent card header text changed to "peek wants your approval" with added comments; test assertion tightened to exact match.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: making the Slack consent-card header neutral for both act and egress flows.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/connector-consent-header

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harry-harish

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@harry-harish harry-harish merged commit 8317cd5 into main Jul 10, 2026
7 checks passed
@harry-harish harry-harish deleted the fix/connector-consent-header branch July 10, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant