Skip to content

fix(connector-slack): neutral consent-card header (fits act + egress) #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harry-harish merged 1 commit into from
Jul 10, 2026
Merged

fix(connector-slack): neutral consent-card header (fits act + egress) #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/connector-slack/src/blockkit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ describe('consentCard delegated path (summary only, empty details)', () => {
const header = blocks.find((b) => b.type === 'header') as
| { text: { text: string } }
| undefined;
expect(header?.text.text).toContain('peek wants to act');
// Neutral header (serves act, delegated-act, AND egress); the summary carries specifics.
expect(header?.text.text).toBe('peek wants your approval');
const section = blocks.find((b) => b.type === 'section') as
| { text: { text: string } }
| undefined;
Expand Down
5 changes: 4 additions & 1 deletion packages/connector-slack/src/blockkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,10 @@ export function consentCard(
const value = APPROVE_BUTTON_VALUE(correlationId, conversationId);
const header: KnownBlock = {
type: 'header',
text: { type: 'plain_text', text: 'peek wants to act on your browser' },
// Neutral header: one consent card serves acting on the browser, delegated
// acts, AND data egress (share_session). The summary sentence below always
// carries the specific request, so the header stays action-agnostic.
text: { type: 'plain_text', text: 'peek wants your approval' },
};
const context: KnownBlock = {
type: 'context',
Expand Down
Loading