docs: finish cluster_weights->cluster_counts terminology cleanup#107
Conversation
Follow-up to #105. Rename the leftover user-facing "weight" labels and column names to "count", and the matching test, so nothing displays the old term: - getting-started.ipynb: "Cluster weights" print label and the to_dataframe("weight") column -> "count". - multi-dim.ipynb: prose "Cluster weights" and to_dataframe("weight") column -> "count". - test_parametrized: test_cluster_occurrences_matches_weights -> ..._matches_counts. Skipped the reviewer's docstring-section suggestions (Returns on the cluster_weights/n_clusters properties; Args/Returns/Raises on _cluster_counts and _validate_no_cluster_config_weights): the codebase convention is prose one-liners for trivial properties and private helpers, with structured sections only on the public aggregate() and public methods that take real parameters. Adding them would break that local consistency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #105 addressing review findings.
Fixed (still-valid terminology leftovers)
The
cluster_weights→cluster_countsrename in #105 left a few user-facing spots still saying "weight":"Cluster weights (days each represents):"print label andto_dataframe("weight")column → count."Cluster weights, …"andto_dataframe("weight")column → count.test_cluster_occurrences_matches_weights→test_cluster_occurrences_matches_counts(implementation unchanged).Skipped (with reason)
The docstring-section suggestions (add
Returns:to thecluster_weights/n_clustersproperties; addArgs:/Returns:/Raises:to_cluster_countsand_validate_no_cluster_config_weights) were not applied. The codebase convention is prose one-liners for trivial@propertyaccessors and private helpers, with structured Google-style sections used only on the publicaggregate()and public methods that take real parameters. Adding sections to these would break that local consistency.Validation
test/test_parametrized.py -k cluster_occurrences→ 21 passed (tsam 3.4.x).ruff check/ruff formatclean; pre-commit hooks pass.🤖 Generated with Claude Code