Skip to content

Fix PyTorch FFT None axis alias handling#3421

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-pytorch-fft-none-axis-dim
Jun 29, 2026
Merged

Fix PyTorch FFT None axis alias handling#3421
FlorianPfaff merged 2 commits into
mainfrom
fix-pytorch-fft-none-axis-dim

Conversation

@FlorianPfaff

@FlorianPfaff FlorianPfaff commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve an explicit PyTorch dim argument when the NumPy-style FFT axis alias is provided as None
  • keep conflicting non-None axis/axes and dim arguments rejected
  • add a regression test covering axes=None, dim=(0,) for fftn/ifftn

Bug

The PyTorch FFT wrapper translated axis/axes aliases by always assigning kwargs["dim"] = alias_value. When axes=None was passed together with an explicit dim, this overwrote the requested dimension with None, so transforms were evaluated over the default axes instead of the caller-specified axes.

Testing

  • Validated the specific alias-normalization behavior with a local Torch/NumPy snippet.
  • Full GitHub Actions CI is queued on the PR.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 67.16s
✅ JSON prettier 7 0 0 0 0.91s
✅ JSON v8r 7 0 0 3.47s
✅ MARKDOWN markdownlint 68 0 0 0 1.73s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.83s
✅ PYTHON black 1121 10 0 0 55.66s
✅ PYTHON isort 1121 15 0 0 3.38s
✅ REPOSITORY checkov yes no no 43.05s
✅ REPOSITORY gitleaks yes no no 10.88s
✅ REPOSITORY git_diff yes no no 0.12s
✅ REPOSITORY secretlint yes no no 42.92s
✅ REPOSITORY syft yes no no 6.03s
✅ REPOSITORY trivy-sbom yes no no 6.05s
✅ REPOSITORY trufflehog yes no no 16.8s
✅ YAML prettier 11 0 0 0 0.61s
✅ YAML v8r 11 0 0 10.16s
✅ YAML yamllint 11 0 0 0.52s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 72a1562 into main Jun 29, 2026
14 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant