Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/pyrecest/_backend/pytorch/fft.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ def _with_dim_alias(kwargs, alias, func_name):
kwargs = dict(kwargs)
alias_value = kwargs.pop(alias)
dim_value = kwargs.get("dim")
if dim_value is not None and alias_value is not None and dim_value != alias_value:
raise TypeError("conflicting FFT axis aliases")
if dim_value is not None:
if alias_value is not None and dim_value != alias_value:
raise TypeError("conflicting FFT axis aliases")
return kwargs
kwargs["dim"] = alias_value
return kwargs

Expand Down
18 changes: 18 additions & 0 deletions tests/backend_support/test_pytorch_fft_axis_contract.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,24 @@ def test_raw_pytorch_fft_helpers_accept_numpy_axis_aliases():
)


@pytest.mark.backend_portable
def test_raw_pytorch_fft_none_axis_alias_preserves_explicit_dim():
matrix = np.arange(6.0).reshape(2, 3)

npt.assert_allclose(
pytorch_fft.fftn(matrix.tolist(), axes=None, dim=(0,)).numpy(),
np.fft.fftn(matrix, axes=(0,)),
)
npt.assert_allclose(
pytorch_fft.ifftn(
pytorch_fft.fftn(matrix, dim=(0,)),
axes=None,
dim=(0,),
).numpy(),
np.fft.ifftn(np.fft.fftn(matrix, axes=(0,)), axes=(0,)),
)


def test_raw_pytorch_fft_rejects_conflicting_axis_aliases():
with pytest.raises(TypeError):
pytorch_fft.rfft(np.arange(4.0), axis=0, dim=1)
Loading