Desktop: support multicam filter pipelines (filter_*_2-cam / 3-cam)#1786
Open
mattdawkins wants to merge 1 commit into
Open
Desktop: support multicam filter pipelines (filter_*_2-cam / 3-cam)#1786mattdawkins wants to merge 1 commit into
mattdawkins wants to merge 1 commit into
Conversation
Pipes with a camera suffix are categorized under '2-cam'/'3-cam', so a multicam filter pipe like filter_register_frames_2-cam.pipe never matched the type === 'filter' checks: its image writers got no output prefix and no new dataset was created from the results. Filter output handling is now recognized from the pipe filename as well as the type, and the output prefix is passed to the per-camera writers (image_writer, image_writer2, image_writer3) that multicam filter pipes use; extra -s keys for absent processes are ignored by the runner. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pipeline categories come from the pipe filename, and a
2-cam/3-camsuffix overrides the prefix — so a multicam filter pipeline (e.g. VIAME's newfilter_register_frames_2-cam.pipeandfilter_compute_tile_mosaics_2-cam.pipe, which write registered/blacked-out images and per-timestep tile mosaics) is typed2-cam, never matches thetype === 'filter'checks, and consequently: its image writers get no output-directory prefix, its (nonexistent) CSVs are ingested, and no new dataset is created from the output images.Fix
Desktop
runPipelinenow recognizes filter/transcode output handling from the pipe filename prefix as well as the resolved type:createsNewDataset/isFilterPipeare true forfilter_*.piperegardless of the-camcategory, enabling output-dir creation, CSV-ingest skip, image-writer prefixing, frame renumbering, and new-dataset import.image_writer2/image_writer3, the per-camera writers multicam filter pipes use (extra-skeys for absent processes are ignored by the kwiver runner).Web/girder pipeline running is untouched.
🤖 Generated with Claude Code