Skip to content

Desktop: support multicam filter pipelines (filter_*_2-cam / 3-cam) #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattdawkins wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Desktop: support multicam filter pipelines (filter_*_2-cam / 3-cam) #1786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions client/platform/desktop/backend/native/viame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,13 @@ async function runPipeline(
): Promise<DesktopJob> {
const { datasetId, pipeline } = runPipelineArgs;
const frameRange = runPipelineArgs.pipelineParams?.runtimeParams?.frameRange ?? undefined;
// Pipes with a camera suffix (e.g. filter_register_frames_2-cam.pipe) are
// categorized under '2-cam'/'3-cam' rather than by their filename prefix,
// so output handling (image writing, new-dataset creation) is recognized
// from the pipe filename as well as the type.
const createsNewDataset = pipelineCreatesDatasetMarkers.includes(pipeline.type)
|| pipelineCreatesDatasetMarkers.some((marker) => pipeline.pipe.startsWith(`${marker}_`));
const isFilterPipe = pipeline.type === 'filter' || pipeline.pipe.startsWith('filter_');

const isValid = await validateViamePath(settings);
if (isValid !== true) {
Expand All @@ -175,7 +182,7 @@ async function runPipeline(
const timestamp = (new Date()).toISOString().replace(/[:.]/g, '-');
const outputDirName = `${runPipelineArgs.pipeline.name}_${runPipelineArgs.datasetId}_${timestamp}`;
const outputDir = `${npath.join(settings.dataPath, JobsOutputFolderName, outputDirName)}`;
if (pipelineCreatesDatasetMarkers.includes(runPipelineArgs.pipeline.type)) {
if (createsNewDataset) {
if (outputDir !== jobWorkDir) {
await fs.mkdir(outputDir, { recursive: true });
}
Expand All @@ -185,7 +192,7 @@ async function runPipeline(
const trackOutputFileName = 'track_output.csv';
let trackOutput: string;
let detectorOutput: string;
if (pipelineCreatesDatasetMarkers.includes(runPipelineArgs.pipeline.type)) {
if (createsNewDataset) {
detectorOutput = npath.join(outputDir, detectorOutputFileName);
trackOutput = npath.join(outputDir, trackOutputFileName);
} else {
Expand Down Expand Up @@ -246,7 +253,7 @@ async function runPipeline(
command.push(`-s downsampler:frame_range_is_native=${isNative}`);
// Transcode/filter pipes: output frames renumbered relative to new range
// All other pipes: output frames relative to original video
const renumber = pipeline.type === 'transcode' || pipeline.type === 'filter';
const renumber = pipeline.type === 'transcode' || isFilterPipe;
command.push(`-s downsampler:renumber_frames=${renumber}`);
command.push(`-s downsampler:adjust_timestamps=${renumber}`);
}
Expand Down Expand Up @@ -285,9 +292,14 @@ async function runPipeline(
}
}

if (runPipelineArgs.pipeline.type === 'filter') {
if (isFilterPipe) {
command.push(`-s kwa_writer:output_directory="${outputDir}/"`);
// Multicam filter pipes have one writer per camera (image_writer,
// image_writer2, image_writer3); extra -s keys for absent processes are
// ignored by the runner.
command.push(`-s image_writer:file_name_prefix="${outputDir}/"`);
command.push(`-s image_writer2:file_name_prefix="${outputDir}/"`);
command.push(`-s image_writer3:file_name_prefix="${outputDir}/"`);
}

let transcodedFilename: string;
Expand Down Expand Up @@ -395,7 +407,7 @@ async function runPipeline(
job.on('exit', async (code) => {
if (code === 0) {
try {
if (!pipelineCreatesDatasetMarkers.includes(runPipelineArgs.pipeline.type)) {
if (!createsNewDataset) {
let finalDetectorOutput = detectorOutput;
let finalTrackOutput = trackOutput;

Expand Down Expand Up @@ -429,7 +441,7 @@ async function runPipeline(
}

// Check if this is a transcode/filter pipeline and create a new dataset
if (pipelineCreatesDatasetMarkers.includes(runPipelineArgs.pipeline.type)) {
if (createsNewDataset) {
updater({
...jobBase,
body: ['Creating dataset from output...'],
Expand Down
Loading