Skip to content

feat: added settiings button in the mobile view.#1053

Merged
coodos merged 3 commits into
mainfrom
feat/mobileSettings
Jun 26, 2026
Merged

feat: added settiings button in the mobile view.#1053
coodos merged 3 commits into
mainfrom
feat/mobileSettings

Conversation

@Sahil2004

@Sahil2004 Sahil2004 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description of change

Added settings button at the top in the mobile view only in the profile page because that makes the most sense instead of doing it on every page.

image

Issue Number

Closes #1040

Type of change

  • New (a change which implements a new feature)
  • Fix (a change which fixes an issue)

How the change has been tested

Manually

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features

    • Added mobile-only Settings shortcut button in the header for quick navigation.
  • Style

    • Enhanced back button icon color for improved visibility.
    • Refined Profile tab selected state indicator styling.

@Sahil2004 Sahil2004 requested a review from coodos as a code owner June 23, 2026 05:09
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Sahil2004, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 9 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd8aee8e-ff74-48f9-a307-812cca3ce6cf

📥 Commits

Reviewing files that changed from the base of the PR and between 0668113 and 56f0853.

📒 Files selected for processing (1)
  • platforms/pictique/client/src/lib/fragments/Header/Header.svelte
📝 Walkthrough

Walkthrough

The Header.svelte fragment adds a mobile-only (md:hidden) Settings shortcut button that conditionally renders when the current route does not include /settings, navigating via goto('/settings'). The back-button color token is darkened from var(--color-black-500) to var(--color-black-800). In BottomNav.svelte, the fullPath derived variable is removed and the Profile tab's active-border condition no longer includes fullPath.includes('settings').

Changes

Mobile Settings Access & Navigation Fix

Layer / File(s) Summary
BottomNav active-state cleanup
platforms/pictique/client/src/lib/fragments/BottomNav/BottomNav.svelte
Replaces the fullPath derived value with _activeTab and removes the fullPath.includes('settings') check so the Profile tab border is no longer activated by settings routes.
Header mobile Settings button and back-button color
platforms/pictique/client/src/lib/fragments/Header/Header.svelte
Reorders imports, updates the back-button color token to var(--color-black-800), and adds a md:hidden Settings button that conditionally renders when the route does not include /settings, using goto('/settings') on click with an aria-label and Settings icon.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • coodos
  • sosweetham
  • pixel-punk-20

Poem

🐇 Hop hop, a button appears on small screens,
No more lost settings in mobile-view scenes!
The profile border no longer goes astray,
When settings routes come hopping your way.
A darker arrow points the path just right —
This rabbit fixed your nav tonight! 🌙

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title describes adding a settings button in mobile view, which matches the main change, though it contains a typo ('settiings' instead of 'settings').
Linked Issues check ✅ Passed The PR addresses issue #1040 by adding a Settings button in the mobile view Header component, directly fulfilling the requirement for settings accessibility in mobile UI.
Out of Scope Changes check ✅ Passed All changes are scoped to adding the mobile settings button feature. The BottomNav.svelte change (activeTab logic) appears to be a related refinement for consistent profile tab styling behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description includes all required sections from the template with complete information: clear change description with visual evidence, issue number, type of change marked, testing method specified, and all checklist items completed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/mobileSettings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@platforms/pictique/client/src/lib/fragments/Header/Header.svelte`:
- Around line 115-123: The onclick handler in the button element is using
goto('/settings') directly, which violates the
svelte/no-navigation-without-resolve rule and is not base-path-safe. Replace the
goto('/settings') call with goto(resolve('/settings')) to properly resolve the
internal navigation path using the resolve function, ensuring the navigation
respects the configured base path and follows the Svelte linting rules.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d05e07b3-7efb-4a9e-a62e-7affe5e4c107

📥 Commits

Reviewing files that changed from the base of the PR and between 77eb934 and 0668113.

📒 Files selected for processing (2)
  • platforms/pictique/client/src/lib/fragments/BottomNav/BottomNav.svelte
  • platforms/pictique/client/src/lib/fragments/Header/Header.svelte

Comment thread platforms/pictique/client/src/lib/fragments/Header/Header.svelte Outdated
@coodos coodos merged commit 924f33f into main Jun 26, 2026
4 checks passed
@coodos coodos deleted the feat/mobileSettings branch June 26, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings button not available in mobile view — Pictique

2 participants