Add correct comment to supported variable conversions.#767
Conversation
climbfuji
left a comment
There was a problem hiding this comment.
This PR needs a few more updates. There are 20-ish unit test failures because the two new arguments to ResolvedArg are mandatory. I'll create a PR that incorporates your changes, fixes those, and targets the cleanup-01 branch instead of feature/capgen-v1 (that would have caught the test failures, because the cleanp-01 branch activates the CI testing for PRs against feature/capgen-v1).
I'll also add the info/debug output for unit and kind conversions as applicable.
|
@dustinswales See #768 This doesn't include the debug prints for unit/type conversions yet. They should come in via a separate PR (will create once #768 is merged into https://github.com/NCAR/ccpp-framework/tree/feature/capgen-v1-cleanup-01). We can leave this PR open or close it as superseded by #768. |
|
Superseded by #768 |
Description
@climbfuji This is a small one to fix the trailing comments after the variable conversions in the Group caps.
Also, I couldn't find any message alerting us that a variable conversion is encountered? I think we should add something like is done in Prebuid:
INFO: Automatic unit conversion from m to um for effective_radius_of_stratiform_cloud_snow_particle_in_um after returning from MODULE_mp_thompson SCHEME_mp_thompson SUBROUTINE_mp_thompson_run
If you agree, I can do this.