Skip to content

Add correct comment to supported variable conversions.#767

Closed
dustinswales wants to merge 1 commit into
NCAR:feature/capgen-v1from
dustinswales:feature/capgen-v1-djs
Closed

Add correct comment to supported variable conversions.#767
dustinswales wants to merge 1 commit into
NCAR:feature/capgen-v1from
dustinswales:feature/capgen-v1-djs

Conversation

@dustinswales

Copy link
Copy Markdown
Member

Description

@climbfuji This is a small one to fix the trailing comments after the variable conversions in the Group caps.
Also, I couldn't find any message alerting us that a variable conversion is encountered? I think we should add something like is done in Prebuid:
INFO: Automatic unit conversion from m to um for effective_radius_of_stratiform_cloud_snow_particle_in_um after returning from MODULE_mp_thompson SCHEME_mp_thompson SUBROUTINE_mp_thompson_run
If you agree, I can do this.

@dustinswales dustinswales requested review from a team as code owners July 13, 2026 15:51

@climbfuji climbfuji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a few more updates. There are 20-ish unit test failures because the two new arguments to ResolvedArg are mandatory. I'll create a PR that incorporates your changes, fixes those, and targets the cleanup-01 branch instead of feature/capgen-v1 (that would have caught the test failures, because the cleanp-01 branch activates the CI testing for PRs against feature/capgen-v1).

I'll also add the info/debug output for unit and kind conversions as applicable.

@climbfuji

Copy link
Copy Markdown
Collaborator

@dustinswales See #768

This doesn't include the debug prints for unit/type conversions yet. They should come in via a separate PR (will create once #768 is merged into https://github.com/NCAR/ccpp-framework/tree/feature/capgen-v1-cleanup-01).

We can leave this PR open or close it as superseded by #768.

@dustinswales

Copy link
Copy Markdown
Member Author

Superseded by #768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants