[feature/capgen-v1-cleanup-01] Add correct comment to supported variable conversions (#767) + bug fixes + unit test updates#768
Open
climbfuji wants to merge 3 commits into
Open
Conversation
climbfuji
changed the title
climbfuji
commented
Jul 13, 2026
| """The trailing inline comment must list every active transform, but | ||
| must suppress "unit conversion" when the rendered formula is the | ||
| identity (formula ``'{var}'`` for dimensionally-equivalent units). | ||
| """The trailing inline comment must list every active transform with the |
Collaborator
Author
There was a problem hiding this comment.
I'll clean those comments up when I get to this file in my review of the entire code base (I just finished phase 1, subdirectory metadata/parse_tools)
climbfuji
commented
Jul 13, 2026
| self.assertEqual(_transform_comment(a, reverse=True), | ||
| '! unit conversion: km to m') | ||
|
|
||
| def test_unit_conversion_never_reports_kinds(self): |
Collaborator
Author
There was a problem hiding this comment.
Same here. I am not sure that we need unit tests for comments in auto-generated code.
peverwhee
approved these changes
Jul 13, 2026
Collaborator
Author
|
@dustinswales Can you review and approve/request changes when you get a chance, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR #767 (thanks @dustinswales for this contribution) with a few bug fixes and unit test updates.
It now targets the branch
feature/capgen-v1-cleanup-01instead offeature/capgen-v1.I ran the doctests, unit tests, and end-to-end tests locally - they all passed.