Skip to content

Integrate osv-scanner workflow#241

Open
smoy wants to merge 2 commits into
NVIDIA:mainfrom
smoy:feat/osv-scanner-integration
Open

Integrate osv-scanner workflow#241
smoy wants to merge 2 commits into
NVIDIA:mainfrom
smoy:feat/osv-scanner-integration

Conversation

@smoy

@smoy smoy commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Integrate osv-scanner github action to leverage the vulnerability scanner on every pr

This is an example if osv-scanner find something

Signed-off-by: Steven Moy <github@stevenmoy.com>

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Automated SkillSpector Review]

Requesting changes. The reusable OSV workflows are commit-pinned and CI is green, but shipping a repository-wide malware advisory exception is not justified. Package removal does not make a locked or vendored malicious dependency safe; remove the exception or provide narrowly scoped, evidence-backed, time-bounded handling that cannot hide a real dependency finding.

Comment thread osv-scanner.toml
@@ -0,0 +1,4 @@
[[IgnoredVulns]]
id = "MAL-2026-6561"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: do not globally suppress a MAL-* advisory merely because a registry removed the package. If this repository actually references the affected package, that is exactly what the scanner should report; if it does not, no ignore is needed. Remove this entry, or document and enforce a narrowly scoped, expiring exception with evidence.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rng1995 I have added ignoreUntil to until 2026-07-20

Any plans for the repo maintainer to claim that namespace in pypi to avoid future incidents?

I open issue #240 to mention the process to ask pypi to transfer ownership to copyright owner.

https://docs.pypi.org/project-management/name-retention/#how-to-request-a-name-transfer

Signed-off-by: Steven Moy <github@stevenmoy.com>
@smoy smoy requested a review from rng1995 July 9, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants