-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Integrate osv-scanner workflow #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smoy
wants to merge
2
commits into
NVIDIA:main
Choose a base branch
from
smoy:feat/osv-scanner-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name: OSV-Scanner | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: ["main"] | ||
| merge_group: | ||
| types: [checks_requested] | ||
| schedule: | ||
| - cron: "12 12 * * 1" | ||
| push: | ||
| branches: ["main"] | ||
|
|
||
| permissions: | ||
| # Required to upload SARIF file to CodeQL. See: https://github.com/github/codeql-action/issues/2117 | ||
| actions: read | ||
| # Require writing security events to upload SARIF file to security tab | ||
| security-events: write | ||
| # Read commit contents | ||
| contents: read | ||
|
|
||
| jobs: | ||
| scan-scheduled: | ||
| if: ${{ github.event_name == 'push' || github.event_name == 'schedule' }} | ||
| uses: "google/osv-scanner-action/.github/workflows/osv-scanner-reusable.yml@3adb4b14a2b0623876d18d863a498b785fb3752d" # v2.3.8 | ||
| with: | ||
| # Example of specifying custom arguments | ||
| scan-args: |- | ||
| --include-git-root | ||
| -r | ||
| ./ | ||
| scan-pr: | ||
| if: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} | ||
| uses: "google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@3adb4b14a2b0623876d18d863a498b785fb3752d" # v2.3.8 | ||
| with: | ||
| # Example of specifying custom arguments | ||
| scan-args: |- | ||
| --include-git-root | ||
| -r | ||
| ./ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| [[IgnoredVulns]] | ||
| id = "MAL-2026-6561" | ||
| ignoreUntil = 2026-07-20 # Hopefully, legitmate package owner will claim the namespace in pypi | ||
| reason = "No actual action can be taken as the pypi has already removed it" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: do not globally suppress a
MAL-*advisory merely because a registry removed the package. If this repository actually references the affected package, that is exactly what the scanner should report; if it does not, no ignore is needed. Remove this entry, or document and enforce a narrowly scoped, expiring exception with evidence.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rng1995 I have added ignoreUntil to until 2026-07-20
Any plans for the repo maintainer to claim that namespace in pypi to avoid future incidents?
I open issue #240 to mention the process to ask pypi to transfer ownership to copyright owner.
https://docs.pypi.org/project-management/name-retention/#how-to-request-a-name-transfer