Remove ROS 2 Humble support#58
Merged
Merged
Conversation
📝 WalkthroughWalkthroughChangesJazzy CI and base-image alignment
🔕 Pre-merge checks override appliedThe pre-merge checks have been overridden successfully. You can now proceed with the merge. Overridden by ❌ Failed checks (1 error)
✅ Passed checks (3 passed)
Comment |
marty-mcfly-bot
Bot
force-pushed
the
chore/remove-ros-humble
branch
from
July 17, 2026 20:53
1cabf91 to
3fe7ed3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Line 18: Update the reusable workflow invocation in the CI configuration to
replace secrets: inherit with an explicit secrets mapping containing only
moveit_license_key and the optional lfs_cache_role_arn. Preserve the existing
workflow reference and ensure the optional secret remains available when
configured.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3d639d77-770c-40f5-8d5d-bcfa4cadbaa5
📒 Files selected for processing (2)
.github/workflows/ci.yamlDockerfile
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 17-24: Add a permissions block to the
integration-test-in-studio-container reusable workflow invocation, granting
contents read and id-token write. Keep the existing uses, inputs, and secrets
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4412773b-77e6-4e15-b55c-1c5776659543
📒 Files selected for processing (2)
.github/workflows/ci.yamlDockerfile
🚧 Files skipped from review as they are similar to previous changes (1)
- Dockerfile
marty-mcfly-bot
Bot
force-pushed
the
chore/remove-ros-humble
branch
from
July 17, 2026 20:55
3fe7ed3 to
e09dc11
Compare
marty-mcfly-bot
Bot
force-pushed
the
chore/remove-ros-humble
branch
from
July 17, 2026 20:56
e09dc11 to
c3c2f3e
Compare
JWhitleyWork
approved these changes
Jul 17, 2026
JWhitleyWork
pushed a commit
that referenced
this pull request
Jul 17, 2026
Co-authored-by: marty-mcfly-bot[bot] <marty-mcfly-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Summary
moveit_pro_civ0.9.0 so the caller can select its ROS distribution.This is the upstream shared-workspace portion of PickNikRobotics#792 and a companion to PickNikRobotics/moveit_pro#20494. After this merges,
moveit_pro_example_ws/maincan be rebased on this repository and #792 can retain only its example-workspace-specific changes.Verification
pre-commit run --all-filesdocker build --progress=plain --target base -t moveit-pro-empty-ws:remove-humble .Release notes
Enhancement:Removed ROS 2 Humble support from the default MoveIt Pro workspace, which now targets ROS 2 Jazzy.