Skip to content

Remove ROS 2 Humble support#58

Merged
JWhitleyWork merged 1 commit into
mainfrom
chore/remove-ros-humble
Jul 17, 2026
Merged

Remove ROS 2 Humble support#58
JWhitleyWork merged 1 commit into
mainfrom
chore/remove-ros-humble

Conversation

@marty-mcfly-bot

Copy link
Copy Markdown
Contributor

[written by AI]

Summary

  • Make ROS 2 Jazzy the default MoveIt Pro base-image distribution.
  • Upgrade the reusable workspace integration workflow to moveit_pro_ci v0.9.0 so the caller can select its ROS distribution.
  • Run workspace integration CI only on Jazzy.

This is the upstream shared-workspace portion of PickNikRobotics#792 and a companion to PickNikRobotics/moveit_pro#20494. After this merges, moveit_pro_example_ws/main can be rebased on this repository and #792 can retain only its example-workspace-specific changes.

Verification

  • pre-commit run --all-files
  • docker build --progress=plain --target base -t moveit-pro-empty-ws:remove-humble .
  • Verified both changed files contain Jazzy-only defaults and no Humble references.

Release notes

Enhancement: Removed ROS 2 Humble support from the default MoveIt Pro workspace, which now targets ROS 2 Jazzy.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Jazzy CI and base-image alignment

Layer / File(s) Summary
Jazzy CI and image defaults
.github/workflows/ci.yaml, Dockerfile
The integration-test job uses reusable workflow revision v0.9.0 with ros_distros set to Jazzy and an explicit license-key secret, while the Dockerfile defaults MOVEIT_ROS_DISTRO to Jazzy for base-image selection.

🔕 Pre-merge checks override applied

The pre-merge checks have been overridden successfully. You can now proceed with the merge.

Overridden by @JWhitleyWork via checkbox on 2026-07-17T21:11:30.871Z.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Human Review Check ❌ Error [IGNORED] PR changes CI workflow permissions/secrets and workflow inputs, which is CI/CD infra and not low-risk. This PR requires review by a requested human reviewer. After review, a non-author requested reviewer should override this pre-merge check.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description matches the PR changes, covering the Jazzy default image and the updated workspace integration workflow.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yaml:
- Line 18: Update the reusable workflow invocation in the CI configuration to
replace secrets: inherit with an explicit secrets mapping containing only
moveit_license_key and the optional lfs_cache_role_arn. Preserve the existing
workflow reference and ensure the optional secret remains available when
configured.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d639d77-770c-40f5-8d5d-bcfa4cadbaa5

📥 Commits

Reviewing files that changed from the base of the PR and between ba5cf01 and 1cabf91.

📒 Files selected for processing (2)
  • .github/workflows/ci.yaml
  • Dockerfile

Comment thread .github/workflows/ci.yaml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 17-24: Add a permissions block to the
integration-test-in-studio-container reusable workflow invocation, granting
contents read and id-token write. Keep the existing uses, inputs, and secrets
unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4412773b-77e6-4e15-b55c-1c5776659543

📥 Commits

Reviewing files that changed from the base of the PR and between 1cabf91 and 3fe7ed3.

📒 Files selected for processing (2)
  • .github/workflows/ci.yaml
  • Dockerfile
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile

Comment thread .github/workflows/ci.yaml
@marty-mcfly-bot
marty-mcfly-bot Bot force-pushed the chore/remove-ros-humble branch from 3fe7ed3 to e09dc11 Compare July 17, 2026 20:55
@marty-mcfly-bot
marty-mcfly-bot Bot force-pushed the chore/remove-ros-humble branch from e09dc11 to c3c2f3e Compare July 17, 2026 20:56
@JWhitleyWork
JWhitleyWork merged commit 0d7e95a into main Jul 17, 2026
4 checks passed
@JWhitleyWork
JWhitleyWork deleted the chore/remove-ros-humble branch July 17, 2026 21:11
JWhitleyWork pushed a commit that referenced this pull request Jul 17, 2026
Co-authored-by: marty-mcfly-bot[bot] <marty-mcfly-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant