Reuse E2E auth state during app cleanup#7961
Merged
Merged
Conversation
github-actions
Bot
added
the
no-changelog
Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
alfonso-noriega
force-pushed
the
06-30-e2e_cleanup_reuse_auth
branch
from
4b3369e to
cb7a258
Compare
isaacroldan
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Current-run E2E app cleanup re-authenticates through Shopify Accounts after Playwright global setup already created browser storage state. In CI this contributes to Accounts 429s before cleanup can list/delete apps.
WHAT is this pull request doing?
E2E_BROWSER_STATE_PATHor the default.e2e-tmp/global-auth/browser-storage-state.jsonwhen present.scripts/prime-browser-auth.tsso standalone cleanup jobs can create the same storage state before cleanup.How to test your changes?
cd packages/e2e && pnpm tsc --noEmitruby -e 'require "yaml"; YAML.load_file(".github/workflows/tests-pr.yml"); puts "YAML OK"'\n\nNote:pnpm nx run e2e:type-checkcurrently fails on@shopify/organizationstype resolution in app/store build dependencies in this worktree, before reaching this cleanup script.