Fix: use direct Schema access instead of broken engine vtable calls#22
Open
Tsukasa-Nefren wants to merge 1 commit into
Open
Fix: use direct Schema access instead of broken engine vtable calls#22Tsukasa-Nefren wants to merge 1 commit into
Tsukasa-Nefren wants to merge 1 commit into
Conversation
Replaced IVEngineServer::GetClientSteamID and IServerGameClients::GetPlayerScore vtable calls with direct CCSPlayerController Schema field access (m_steamID, m_iScore). This avoids breakage from CS2 engine updates that shifted CPlayerSlot to CEntityIndex.
Contributor
|
I don't believe these changes are really needed, the existing setup works fine with an SDK rebuild, just an alternative way of doing things. Even if this was just for reducing future update maintenance of similar breakage, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.