chore: updated deployment scripts - #455
Conversation
Add price bounds, timestamp validation, market caps, liquidation pause, and emergency guardian controls. Remove fixed oracle pegs, enforce mainnet deployment guards, correct tzBTC configuration, and pin reproducible SmartPy 0.16.0 builds.
KevinMehrabi
left a comment
There was a problem hiding this comment.
Thank you for the update. I am holding approval until the findings in TEZFIN_PR_455_V3_1_FOLLOW_UP_SECURITY_REVIEW_2026_07_21.md are addressed.
Required before approval:
- Correct the supply-cap and borrow-cap checks.
marketTotalsreturns post-operation totals, so the current transaction amount must not be added again. - Add end-to-end ꜰToken tests covering transactions below, exactly at, and above each cap.
- Update
MainnetGovernancePayloads.json. The current86400maximum price age is rejected by the new 3600-second limit. - Add price bounds, supply caps, borrow caps, liquidation pause states, and independent activation controls to the governance payload.
- Make oracle verification mandatory from every mainnet deployment path.
- Reject
priceExp = 0insupportMarket. - Correct the H-02/M-03 documentation: independent liquidation pausing was implemented; the separate guardian/timelock recommendation was not.
- Repeat the complete deployment and governance activation sequence on Previewnet.
The replacement production oracle remains a prerequisite before minting or borrowing can be opened.
|
Thanks, I reviewed the latest commit The remaining blockers are:
The unresolved replacement production oracle remains a blocker to mainnet activation, although it does not need to block merging the deployment code once the items above are resolved. |
No description provided.