Skip to content

PR_26179_CHARLIE_028-sprites-editor-polish#264

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_028-sprites-editor-polish
Jun 28, 2026
Merged

PR_26179_CHARLIE_028-sprites-editor-polish#264
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_028-sprites-editor-polish

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Polish Sprite Creator editor copy and manual validation clarity.
  • Remove outdated wording such as later editor slice while keeping behavior unchanged.
  • Preserve stacked Sprite Editor workflow from PR_26179_CHARLIE_027.

Validation

  • PASS: node --check assets/toolbox/sprites/js/index.js
  • PASS: node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs
  • PASS: git diff --check for touched runtime/test files
  • PASS: targeted Sprite Creator Playwright shell test

Artifact

  • dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 28, 2026 20:14
@ToolboxAid ToolboxAid changed the base branch from PR_26179_CHARLIE_027-sprites-preview-export to main June 28, 2026 20:15
@ToolboxAid ToolboxAid merged commit 44974c9 into main Jun 28, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cece49f22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Team: CHARLIE
Workflow: stacked feature workflow
Base branch: PR_26179_CHARLIE_027-sprites-preview-export
Canonical ZIP path for this batch: dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the required tmp delta ZIP path

The root AGENTS.md packaging rule requires BUILD artifacts at <project folder>/tmp/<TASK_NAME>_delta.zip, but this new report advertises dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip as the canonical path and repeats it later. In packaging/validation contexts that consume this report, the required tmp artifact will be undiscoverable or considered missing even if a ZIP exists in the older location.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant