-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26179_CHARLIE_028-sprites-editor-polish #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
docs_build/dev/reports/PR_26179_CHARLIE_028-sprites-editor-polish.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # PR_26179_CHARLIE_028-sprites-editor-polish | ||
|
|
||
| Team: CHARLIE | ||
| Workflow: stacked feature workflow | ||
| Base branch: PR_26179_CHARLIE_027-sprites-preview-export | ||
| Canonical ZIP path for this batch: dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip | ||
|
|
||
| ## Summary | ||
|
|
||
| Polished Sprite Creator editor copy and status text. Removed stale wording such as "later editor slice" and improved manual validation clarity. Behavior is intentionally unchanged. | ||
|
|
||
| ## Product Owner Testable Outcome | ||
|
|
||
| The Product Owner can open Sprite Creator and verify the editor communicates its current unsaved-draft behavior clearly while all existing editor interactions still work. | ||
|
|
||
| ## Branch Validation | ||
|
|
||
| PASS | ||
|
|
||
| - Current branch: PR_26179_CHARLIE_028-sprites-editor-polish | ||
| - Based on: PR_26179_CHARLIE_027-sprites-preview-export | ||
| - No start_of_day files changed | ||
| - No DB/API/schema files changed | ||
| - No stale PR #219-#228 code copied | ||
|
|
||
| ## Requirement Checklist | ||
|
|
||
| | Requirement | Status | Notes | | ||
| | --- | --- | --- | | ||
| | Fix outdated copy | PASS | Removed "later editor slice" wording. | | ||
| | Improve status/manual validation clarity | PASS | Copy now explains unsaved editor workspace and deferred API-backed library save. | | ||
| | Keep behavior unchanged | PASS | Only HTML copy and Playwright assertions changed. | | ||
| | No DB/API/schema changes | PASS | None changed. | | ||
| | No browser-owned authoritative product data | PASS | No persistence added. | | ||
|
|
||
| ## Validation Lane Report | ||
|
|
||
| Commands: | ||
|
|
||
| ```text | ||
| node --check assets/toolbox/sprites/js/index.js | ||
| node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs | ||
| git diff --check -- toolbox/sprites/index.html dev/tests/playwright/tools/SpritesToolShell.spec.mjs | ||
| rg --pcre2 -n -i "later editor slice|Not implemented yet|future rebuild work|Static wireframe only|Plan sprite creation|localStorage|sessionStorage|indexedDB|imageDataUrl|toDataURL|<style|style=|<script(?![^>]+src=)|on(click|change|submit|input|load|error)=|local-mem|fake-login|MEM DB" toolbox/sprites/index.html assets/toolbox/sprites/js/index.js | ||
| npx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list --output=<temp> | ||
| ``` | ||
|
|
||
| Results: | ||
|
|
||
| - Node syntax checks: PASS | ||
| - `git diff --check`: PASS | ||
| - Guard scan: PASS, no matches in page/runtime files | ||
| - Targeted Playwright: PASS, 1 test passed | ||
|
|
||
| ## Manual Validation Notes | ||
|
|
||
| 1. Open `/toolbox/sprites/index.html`. | ||
| 2. Confirm the tools panel says "Choose a drawing action for the current unsaved sprite draft." | ||
| 3. Confirm the work area explains the sprite library save remains deferred to a future API-backed PR. | ||
| 4. Confirm Pencil/Eraser/Fill, palette, preview, and PNG export still work. | ||
|
|
||
| ## Previous PR Dependency | ||
|
|
||
| PR_26179_CHARLIE_027-sprites-preview-export | ||
|
|
||
| ## Next PR Dependency | ||
|
|
||
| PR_26179_CHARLIE_029-sprites-clear-reset-controls | ||
|
|
||
| ## ZIP Path | ||
|
|
||
| `dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| toolbox/sprites/index.html | ||
| assets/toolbox/sprites/js/index.js | ||
| assets/theme-v2/css/gamefoundrystudio.css | ||
| toolbox/sprites/index.html | ||
| dev/tests/playwright/tools/SpritesToolShell.spec.mjs | ||
| docs_build/dev/reports/PR_26179_CHARLIE_027-sprites-preview-export.md | ||
| docs_build/dev/reports/PR_26179_CHARLIE_028-sprites-editor-polish.md | ||
| docs_build/dev/reports/codex_changed_files.txt | ||
| docs_build/dev/reports/codex_review.diff |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root
AGENTS.mdpackaging rule requires BUILD artifacts at<project folder>/tmp/<TASK_NAME>_delta.zip, but this new report advertisesdev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zipas the canonical path and repeats it later. In packaging/validation contexts that consume this report, the requiredtmpartifact will be undiscoverable or considered missing even if a ZIP exists in the older location.Useful? React with 👍 / 👎.