Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dev/tests/playwright/tools/SpritesToolShell.spec.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ test("Sprite Creator shell loads with visible tool, canvas, details, and status
await expect(page.locator("[data-sprites-work-area]")).toBeVisible();
await expect(page.locator("[data-sprites-details-panel]")).toBeVisible();
await expect(page.locator("[data-sprites-footer-status]")).toBeVisible();
await expect(page.locator("main")).toContainText("Choose a drawing action for the current unsaved sprite draft.");
await expect(page.locator("main")).toContainText("Saving to the sprite library remains deferred");
await expect(page.locator("[data-sprites-tools-panel]")).toContainText("Sprite Tools");
await expect(page.getByText("Drawing Tools", { exact: true })).toBeVisible();
await expect(page.getByText("Canvas Setup", { exact: true })).toBeVisible();
Expand Down Expand Up @@ -274,7 +276,7 @@ test("Sprite Creator shell loads with visible tool, canvas, details, and status
await expect(page.locator("[data-sprites-export-status]")).toContainText("PNG downloaded");
await expect(page.locator("[data-sprites-shell-status]")).toContainText("Editor ready");
await expect(page.locator("main")).toContainText("Palette/Colors remains the reusable color source");
await expect(page.locator("main")).not.toContainText(/Not implemented yet|future rebuild work|Static wireframe only|Plan sprite creation/i);
await expect(page.locator("main")).not.toContainText(/Not implemented yet|future rebuild work|Static wireframe only|Plan sprite creation|later editor slice/i);
await expect(page.locator("style, [style], script:not([src])")).toHaveCount(0);

expect(failures.failedRequests).toEqual([]);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
# PR_26179_CHARLIE_028-sprites-editor-polish

Team: CHARLIE
Workflow: stacked feature workflow
Base branch: PR_26179_CHARLIE_027-sprites-preview-export
Canonical ZIP path for this batch: dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the required tmp delta ZIP path

The root AGENTS.md packaging rule requires BUILD artifacts at <project folder>/tmp/<TASK_NAME>_delta.zip, but this new report advertises dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip as the canonical path and repeats it later. In packaging/validation contexts that consume this report, the required tmp artifact will be undiscoverable or considered missing even if a ZIP exists in the older location.

Useful? React with 👍 / 👎.


## Summary

Polished Sprite Creator editor copy and status text. Removed stale wording such as "later editor slice" and improved manual validation clarity. Behavior is intentionally unchanged.

## Product Owner Testable Outcome

The Product Owner can open Sprite Creator and verify the editor communicates its current unsaved-draft behavior clearly while all existing editor interactions still work.

## Branch Validation

PASS

- Current branch: PR_26179_CHARLIE_028-sprites-editor-polish
- Based on: PR_26179_CHARLIE_027-sprites-preview-export
- No start_of_day files changed
- No DB/API/schema files changed
- No stale PR #219-#228 code copied

## Requirement Checklist

| Requirement | Status | Notes |
| --- | --- | --- |
| Fix outdated copy | PASS | Removed "later editor slice" wording. |
| Improve status/manual validation clarity | PASS | Copy now explains unsaved editor workspace and deferred API-backed library save. |
| Keep behavior unchanged | PASS | Only HTML copy and Playwright assertions changed. |
| No DB/API/schema changes | PASS | None changed. |
| No browser-owned authoritative product data | PASS | No persistence added. |

## Validation Lane Report

Commands:

```text
node --check assets/toolbox/sprites/js/index.js
node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs
git diff --check -- toolbox/sprites/index.html dev/tests/playwright/tools/SpritesToolShell.spec.mjs
rg --pcre2 -n -i "later editor slice|Not implemented yet|future rebuild work|Static wireframe only|Plan sprite creation|localStorage|sessionStorage|indexedDB|imageDataUrl|toDataURL|<style|style=|<script(?![^>]+src=)|on(click|change|submit|input|load|error)=|local-mem|fake-login|MEM DB" toolbox/sprites/index.html assets/toolbox/sprites/js/index.js
npx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list --output=<temp>
```

Results:

- Node syntax checks: PASS
- `git diff --check`: PASS
- Guard scan: PASS, no matches in page/runtime files
- Targeted Playwright: PASS, 1 test passed

## Manual Validation Notes

1. Open `/toolbox/sprites/index.html`.
2. Confirm the tools panel says "Choose a drawing action for the current unsaved sprite draft."
3. Confirm the work area explains the sprite library save remains deferred to a future API-backed PR.
4. Confirm Pencil/Eraser/Fill, palette, preview, and PNG export still work.

## Previous PR Dependency

PR_26179_CHARLIE_027-sprites-preview-export

## Next PR Dependency

PR_26179_CHARLIE_029-sprites-clear-reset-controls

## ZIP Path

`dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip`
6 changes: 2 additions & 4 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
toolbox/sprites/index.html
assets/toolbox/sprites/js/index.js
assets/theme-v2/css/gamefoundrystudio.css
toolbox/sprites/index.html
dev/tests/playwright/tools/SpritesToolShell.spec.mjs
docs_build/dev/reports/PR_26179_CHARLIE_027-sprites-preview-export.md
docs_build/dev/reports/PR_26179_CHARLIE_028-sprites-editor-polish.md
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
Loading
Loading