PR_26179_CHARLIE_034-sprites-frame-strip#271
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67df8ee5db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| box-shadow: 0 1px 4px var(--swatch-shadow-color) | ||
| } | ||
|
|
||
| .sprite-frame-strip { |
There was a problem hiding this comment.
Put frame strip styles in the loaded theme bundle
The Sprite page only loads assets/theme-v2/css/theme.css, and that entrypoint does not import gamefoundrystudio.css (a repo-wide search also finds no active link/import for this file). Because the new .sprite-frame-* rules live only here, the added frame strip/card/thumbnail render with browser defaults instead of the intended Theme V2 strip layout. Please move these rules into an imported stylesheet or wire this stylesheet into the page/theme.
Useful? React with 👍 / 👎.
Summary
Validation
Artifact