Skip to content

PR_26179_CHARLIE_034-sprites-frame-strip#271

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_034-sprites-frame-strip
Jun 28, 2026
Merged

PR_26179_CHARLIE_034-sprites-frame-strip#271
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_034-sprites-frame-strip

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Add a Theme V2 frame strip for the current unsaved Sprite Creator frame.
  • Render the Frame 1 thumbnail from the same page-session editor state.
  • Defer frame editing to the next stacked PR.

Validation

  • PASS: node --check assets/toolbox/sprites/js/index.js
  • PASS: node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs
  • PASS: git diff --check for touched files
  • PASS: targeted Sprite Creator Playwright spec

Artifact

  • dev/workspace/zip/PR_26179_CHARLIE_034-sprites-frame-strip_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 28, 2026 20:18
@ToolboxAid ToolboxAid changed the base branch from PR_26179_CHARLIE_033-sprites-canvas-preview-sync to main June 28, 2026 20:18
@ToolboxAid ToolboxAid merged commit ce49ce7 into main Jun 28, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67df8ee5db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

box-shadow: 0 1px 4px var(--swatch-shadow-color)
}

.sprite-frame-strip {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Put frame strip styles in the loaded theme bundle

The Sprite page only loads assets/theme-v2/css/theme.css, and that entrypoint does not import gamefoundrystudio.css (a repo-wide search also finds no active link/import for this file). Because the new .sprite-frame-* rules live only here, the added frame strip/card/thumbnail render with browser defaults instead of the intended Theme V2 strip layout. Please move these rules into an imported stylesheet or wire this stylesheet into the page/theme.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant