-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26179_CHARLIE_034-sprites-frame-strip #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
docs_build/dev/reports/PR_26179_CHARLIE_034-sprites-frame-strip.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # PR_26179_CHARLIE_034-sprites-frame-strip | ||
|
|
||
| Team: CHARLIE | ||
|
|
||
| Mode: Batch governance stacked feature workflow | ||
|
|
||
| Base branch: PR_26179_CHARLIE_033-sprites-canvas-preview-sync | ||
|
|
||
| Branch: PR_26179_CHARLIE_034-sprites-frame-strip | ||
|
|
||
| ## Summary | ||
|
|
||
| Added a Theme V2-compliant Sprite Creator frame strip for the current unsaved editor frame. The Frame 1 thumbnail mirrors the same page-session editor state as the center canvas and right preview. Frame editing remains deferred to the next scoped PR. | ||
|
|
||
| ## Branch Validation | ||
|
|
||
| PASS | ||
|
|
||
| - Built from `PR_26179_CHARLIE_033-sprites-canvas-preview-sync`. | ||
| - Scope stayed limited to frame strip UI and synced thumbnail rendering. | ||
| - No DB/API/schema changes. | ||
| - No product persistence or browser-owned authoritative product data added. | ||
| - No start_of_day files changed. | ||
| - ZIP package created at the requested path. | ||
|
|
||
| ## Requirement Checklist | ||
|
|
||
| PASS - Added visible Sprite Creator frame strip. | ||
|
|
||
| PASS - Frame strip shows the current unsaved frame. | ||
|
|
||
| PASS - Frame thumbnail renders from page-session editor state. | ||
|
|
||
| PASS - No frame editing behavior added in this slice. | ||
|
|
||
| PASS - Theme V2 CSS used. | ||
|
|
||
| PASS - Targeted Playwright coverage updated. | ||
|
|
||
| ## Validation Lane | ||
|
|
||
| PASS - `node --check assets/toolbox/sprites/js/index.js` | ||
|
|
||
| PASS - `node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs` | ||
|
|
||
| PASS - `git diff --check -- toolbox/sprites/index.html assets/toolbox/sprites/js/index.js assets/theme-v2/css/gamefoundrystudio.css dev/tests/playwright/tools/SpritesToolShell.spec.mjs` | ||
|
|
||
| PASS - Runtime guard scan found no prohibited inline style/script/event-handler or stale placeholder text in touched runtime files. | ||
|
|
||
| PASS - `npx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list` | ||
|
|
||
| ## Manual Validation Notes | ||
|
|
||
| 1. Open `toolbox/sprites/index.html`. | ||
| 2. Confirm the Animation panel shows a Frame 1 strip card. | ||
| 3. Draw a pixel on the center canvas. | ||
| 4. Confirm Frame 1 status updates with painted pixel count. | ||
| 5. Confirm the Frame 1 thumbnail shows the current unsaved draft. | ||
|
|
||
| ## ZIP | ||
|
|
||
| `dev/workspace/zip/PR_26179_CHARLIE_034-sprites-frame-strip_delta.zip` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| assets/theme-v2/css/gamefoundrystudio.css | ||
| assets/toolbox/sprites/js/index.js | ||
| dev/tests/playwright/tools/SpritesToolShell.spec.mjs | ||
| docs_build/dev/reports/PR_26179_CHARLIE_033-sprites-canvas-preview-sync.md | ||
| docs_build/dev/reports/PR_26179_CHARLIE_034-sprites-frame-strip.md | ||
| docs_build/dev/reports/codex_changed_files.txt | ||
| docs_build/dev/reports/codex_review.diff | ||
| toolbox/sprites/index.html |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sprite page only loads
assets/theme-v2/css/theme.css, and that entrypoint does not importgamefoundrystudio.css(a repo-wide search also finds no active link/import for this file). Because the new.sprite-frame-*rules live only here, the added frame strip/card/thumbnail render with browser defaults instead of the intended Theme V2 strip layout. Please move these rules into an imported stylesheet or wire this stylesheet into the page/theme.Useful? React with 👍 / 👎.