Skip to content

fix: treat timer triggers as external resume triggers#137

Open
radu-mocanu wants to merge 1 commit into
mainfrom
feat/runtime-skip-timer-triggers
Open

fix: treat timer triggers as external resume triggers#137
radu-mocanu wants to merge 1 commit into
mainfrom
feat/runtime-skip-timer-triggers

Conversation

@radu-mocanu

@radu-mocanu radu-mocanu commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • skip timer resume triggers in the runtime polling loop
  • keep timer triggers pending until Orchestrator resumes them externally

Depends on: UiPath/uipath-python#1767

Development Package

  • Add this package as a dependency in your pyproject.toml:
[project]
dependencies = [
  # Exact version:
  "uipath-runtime==0.11.5.dev1001370551",

  # Any version from PR
  "uipath-runtime>=0.11.5.dev1001370000,<0.11.5.dev1001380000"
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath-runtime = { index = "testpypi" }

Copilot AI review requested due to automatic review settings June 27, 2026 21:31
@radu-mocanu radu-mocanu requested a review from a team as a code owner June 27, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates resumable runtime behavior so Timer resume triggers are treated as externally resumed (like API/Inbox), preventing the runtime’s auto-resume polling loop from attempting to read them at suspend time. This aligns timer-trigger handling with Orchestrator-driven resume semantics and bumps package versions accordingly.

Changes:

  • Skip UiPathResumeTriggerType.TIMER in UiPathResumableRuntime._get_fired_triggers() polling/auto-resume checks.
  • Update uipath-core dependency to >=0.5.23,<0.6.0 and bump uipath-runtime to 0.11.5.
  • Regenerate uv.lock to reflect the dependency/version updates.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
uv.lock Locks uipath-core to 0.5.23 and updates uipath-runtime metadata to 0.11.5.
src/uipath/runtime/resumable/runtime.py Treats TIMER as an external resume trigger by excluding it from suspend-time polling.
pyproject.toml Bumps project version and updates uipath-core minimum version constraint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/uipath/runtime/resumable/runtime.py
Comment thread src/uipath/runtime/resumable/runtime.py
@radu-mocanu radu-mocanu force-pushed the feat/runtime-skip-timer-triggers branch from 2e5abd3 to 76ea3f8 Compare June 27, 2026 22:25
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants