fix(nodejs): align discovery profile registries#123
Open
ShuoRen-TT wants to merge 1 commit into
Open
Conversation
This was referenced Jul 9, 2026
Author
|
Hi @damaz91 @carolinerg1, could I ask for a quick triage of this Node.js sample fix? It closes #114, includes a focused regression test, and I have rechecked that it merges cleanly with the current main branch. This and #125 are two independently scoped fixes needed to restore a clean The fork-triggered Lint, Conventional Commits, and security workflows are currently marked Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ucp.services["dev.ucp.shopping"]as an array of transport bindingsucp.capabilitiesas a reverse-domain keyed registry whose values are declaration arraysnpm testscriptWhy
The Node.js sample was still emitting the legacy generated discovery shape: a capability array and a service object containing a nested
restproperty. Both the UCP 2026-01-23 schema and current profile examples require keyed capability registries and service-binding arrays.This caused schema-validating clients to reject the Node sample's
/.well-known/ucpresponse and made it inconsistent with other UCP samples.Validation
npm testdiscovery.tsanddiscovery.test.tsThe repository-wide
npm run buildstill reports existing strict TypeScript errors in unrelatedcheckout.ts,order.ts, andtesting.tscode. The changed-file type check passes.Closes #114