Skip to content

ci: build and test Node.js sample#126

Open
ShuoRen-TT wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
ShuoRen-TT:agent/nodejs-build-test-ci
Open

ci: build and test Node.js sample#126
ShuoRen-TT wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
ShuoRen-TT:agent/nodejs-build-test-ci

Conversation

@ShuoRen-TT

@ShuoRen-TT ShuoRen-TT commented Jul 9, 2026

Copy link
Copy Markdown

Summary

  • add a path-filtered GitHub Actions workflow for the Node.js sample
  • install dependencies with Node 20 and npm ci
  • require npm run build to pass
  • run npm test --if-present so current and future Node tests are covered

Why

The repository currently runs pre-commit checks but does not compile or test rest/nodejs. As a result, strict TypeScript errors in the Node.js sample remained undetected across dependency updates.

This workflow adds a focused build gate for changes under rest/nodejs/** without adding work to unrelated sample PRs.

Validation

Dependencies

This draft depends on #123 and #125. The new build job is expected to fail against the current main branch until both existing Node.js compile failures are merged. The workflow deliberately does not use continue-on-error; after those dependencies land, it becomes the regression gate that prevents the same drift from recurring.

@ShuoRen-TT ShuoRen-TT marked this pull request as ready for review July 9, 2026 23:09
@damaz91 damaz91 added the status:needs-triage Signal that the PR is ready for human triage label Jul 9, 2026
vishkaty pushed a commit to vishkaty/samples that referenced this pull request Jul 9, 2026
Path-filter push/pull_request triggers to rest/python/** and the
workflow file itself, matching the path-filtered shape of the Node.js
workflow proposed in Universal-Commerce-Protocol#126, so unrelated changes do not spend CI minutes
booting the Python server.
@vishkaty

vishkaty commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Nice — this gives rest/nodejs the CI coverage that #120 proposes for rest/python (integration tests + server boot + happy-path client). I've borrowed this PR's path-filter shape for #120 so the two workflows stay consistent; happy to align on any other conventions that land here.

vishkaty pushed a commit to vishkaty/samples that referenced this pull request Jul 13, 2026
Path-filter push/pull_request triggers to rest/python/** and the
workflow file itself, matching the path-filtered shape of the Node.js
workflow proposed in Universal-Commerce-Protocol#126, so unrelated changes do not spend CI minutes
booting the Python server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:needs-triage Signal that the PR is ready for human triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants