fix(harness): avoid local files in remote mode

[guslegend0510]

Summary

• Stop creating .index/workspace.db by default when using RemoteFilesystemSpec.
• Disable local Harness session transcript files for remote main agents and subagents.
• Keep AgentStateStore persistence unaffected.
• Make disableSessionPersistence() cover both memory-flush and compaction offload paths.
• Allow callers to explicitly provide a caller-managed WorkspaceIndex when needed.
• Fall back to distributed-store scans when no local workspace index is configured.

Testing

• HarnessAgentTest: 39 tests passed
• Core test suite: 2209 tests passed, 9 skipped
• Harness test suite: 643 tests passed, 3 skipped
• Spotless and git diff --check passed

Fixes #2182

[codecov]

Codecov Report

❌ Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...agent/memory/compaction/ConversationCompactor.java	40.00%	2 Missing and 1 partial ⚠️
...arness/agent/middleware/MemoryFlushMiddleware.java	80.00%	3 Missing ⚠️
...harness/agent/middleware/CompactionMiddleware.java	50.00%	2 Missing ⚠️
...cope/harness/agent/HarnessAgentBuilderSupport.java	50.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[oss-maintainer]

Summary

Fixes remote deployments creating host-local transcript caches. When remoteFilesystemSpec is set, session persistence is now disabled to avoid duplicate storage.

Findings

• [Info] HarnessAgent.java:2044-2048 — Added sessionTranscriptEnabled flag based on remoteFilesystemSpec. Correct.
• [Info] CompactionMiddleware.java and MemoryFlushMiddleware.java — Both now accept sessionPersistenceEnabled parameter. Good separation of concerns.
• [Info] ConversationCompactor.java:156 — Offload step skipped when persistence disabled. Prevents redundant writes.

Verdict

Important fix for remote deployments. LGTM.

---

Automated review by github-manager

[AgentScopeJavaBot]

🤖 AI Review

Well-designed fix for issue #2182 that prevents unnecessary local file creation when using RemoteFilesystemSpec. Three key changes: (1) stops auto-creating .index/workspace.db; (2) disables local session transcripts for remote agents; (3) allows explicit WorkspaceIndex injection when needed. The AgentStateStore persistence path is correctly left unaffected.

All four new tests pass and cover the key scenarios. The sub-agent propagation logic is correct. The fallback to distributed-store scans when no local index exists is properly guarded.

One suggestion: since this is a behavioral change (previously local index was auto-created), consider noting it in release notes so users who relied on the old behavior can explicitly opt in via .workspaceIndex(WorkspaceIndex.open(workspace)).

[AgentScopeJavaBot]

🤖 AI Review

Well-designed fix for issue #2182 that prevents unnecessary local file creation when using RemoteFilesystemSpec. Three key changes: (1) stops auto-creating .index/workspace.db; (2) disables local session transcripts for remote agents; (3) allows explicit WorkspaceIndex injection when needed. The AgentStateStore persistence path is correctly left unaffected.

All four new tests pass and cover the key scenarios. The sub-agent propagation logic is correct. The fallback to distributed-store scans when no local index exists is properly guarded.

One suggestion: since this is a behavioral change (previously local index was auto-created), consider noting it in release notes so users who relied on the old behavior can explicitly opt in via .workspaceIndex(WorkspaceIndex.open(workspace)).