fix(sip_client): use network::get_ip_addresses() for the local-IP fal… - #281
Merged
Conversation
…lback network::get_use_address()/get_use_address_to() was renamed between two ESPHome releases both currently in active use (2026.6.5 still has the old no-arg get_use_address(); 2026.7.2 only has the new buffer-based get_use_address_to()), so either choice broke one of the two. The get_ip_addresses()/IPAddress::str_to()/IP_ADDRESS_BUFFER_SIZE surface is unchanged across both, and returns an actual IP instead of a hostname, which is what this fallback needs anyway. Verified compiling clean against real esphome==2026.6.5 and esphome==2026.7.2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ESPHome 2026.7.0+ requires Python >=3.12, but this workflow pinned Python 3.11, so `pip install esphome` (unpinned) silently fell back to the last 3.11-compatible release (2026.6.5) instead of actually latest. That's why CI compiled against the old, pre-rename network API even though it does an unpinned "pip install esphome" every run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.