Skip to content

fix(sip_client): use network::get_ip_addresses() for the local-IP fal… #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eigger merged 3 commits into from
Jul 27, 2026
+9 −4
Merged

fix(sip_client): use network::get_ip_addresses() for the local-IP fal… #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6bdb37
fix(sip_client): use network::get_ip_addresses() for the local-IP fal…
eigger Jul 27, 2026
156a16e
ci: bump ESPHome CI to Python 3.13
eigger Jul 27, 2026
439eec9
ci: use Python 3.14 (actual latest) instead of 3.13
eigger Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/esphome.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.11'
python-version: '3.14'

- name: Install ESPHome
run: |
Expand All @@ -128,7 +128,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.11'
python-version: '3.14'

- name: Install ESPHome
run: |
Expand Down
9 changes: 7 additions & 2 deletions components/sip_client/sip_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,13 @@ bool SipClient::open_socket_() {
this->socket_->getsockname(reinterpret_cast<struct sockaddr *>(&local), &ll);
this->local_ip_ = sockaddr_ip(local, &this->local_port_);
if (this->local_ip_.empty() || this->local_ip_ == "0.0.0.0") {
char use_address_buf[network::USE_ADDRESS_BUFFER_SIZE];
this->local_ip_ = network::get_use_address_to(use_address_buf);
for (auto &addr : network::get_ip_addresses()) {
if (addr.is_set() && addr.is_ip4()) {
char ip_buf[network::IP_ADDRESS_BUFFER_SIZE];
this->local_ip_ = addr.str_to(ip_buf);
break;
}
}
}
ESP_LOGI(TAG, "SIP socket bound, local %s:%u", this->local_ip_.c_str(), this->local_port_);
return true;
Expand Down