Skip to content

revert: drop clustering dim-rename layer via tsam-xarray DimNames (#739)#746

Merged
FBumann merged 1 commit into
mainfrom
revert-739-artifact-break
Jul 23, 2026
Merged

revert: drop clustering dim-rename layer via tsam-xarray DimNames (#739)#746
FBumann merged 1 commit into
mainfrom
revert-739-artifact-break

Conversation

@FBumann

@FBumann FBumann commented Jul 23, 2026

Copy link
Copy Markdown
Member

Why revert

#739 was labeled refactor: but carries a breaking change for persisted clustering artifacts: clustering JSON/netCDF saved by any flixopt before it no longer loads (_period slice dim vs live period). Under release-please that breakage would ship silently in a v7.x minor.

Policy going forward: main stays fully v7-compatible; breaking changes collect on the v8 integration branch. #739's change lives on there (the v8 branch contains it) and will ship with v8.0.0, where the artifact break is covered by the major version and the migration guide.

Scope

Verification

tests/test_clustering + tests/test_math/test_clustering.py: 275 passed, 0 failed.

⚠️ Note for future main → v8 syncs

Merging main into v8 after this lands will try to apply the revert there too. The next sync must revert this revert on v8 (or resolve the merge keeping v8's side) so #739's change survives where it belongs.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@FBumann, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 743d72b5-46e0-4c86-9230-2f42f1c4a570

📥 Commits

Reviewing files that changed from the base of the PR and between 6962e5e and f058fdc.

📒 Files selected for processing (4)
  • flixopt/clustering/base.py
  • flixopt/transform_accessor.py
  • pyproject.toml
  • tests/test_clustering/test_base.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-739-artifact-break

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FBumann
FBumann merged commit bc18a54 into main Jul 23, 2026
12 checks passed
@FBumann
FBumann deleted the revert-739-artifact-break branch July 23, 2026 17:07
FBumann added a commit that referenced this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant