feat(studio): clip thumbnail modules#2214
Closed
ukimsanov wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 11, 2026
Collaborator
Author
This was referenced Jul 11, 2026
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
c243deb to
8a91e44
Compare
ukimsanov
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
2 times, most recently
from
5c41357 to
6f9c592
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
8a91e44 to
7808aec
Compare
miga-heygen
reviewed
Jul 11, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed as part of the 25-PR NLE overhaul stack. Full stack review on #2205 (the keystone). No blockers on this PR. — Miga
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
47e2df7 to
51e0240
Compare
ukimsanov
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
2 times, most recently
from
2e1046f to
e267beb
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
2 times, most recently
from
3183a29 to
a3a369c
Compare
ukimsanov
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
from
e267beb to
71f29f0
Compare
miguel-heygen
approved these changes
Jul 11, 2026
miguel-heygen
left a comment
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Final rebase review: current head inspected, latest required checks pass, no unresolved blocking findings. Approving; stack order/invariants remain as specified.
ukimsanov
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
from
71f29f0 to
734f785
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
a3a369c to
31fe1ba
Compare
ukimsanov
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
from
734f785 to
31e53ca
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
31fe1ba to
905cea9
Compare
ukimsanov
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
from
31e53ca to
a9924da
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
905cea9 to
c26389a
Compare
ukimsanov
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
from
a9924da to
6e37e12
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
c26389a to
fe4be51
Compare
miguel-heygen
approved these changes
Jul 12, 2026
miguel-heygen
left a comment
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Re-audit current head fe4be51: required checks pass; no new actionable threads. Approving current head.
miguel-heygen
approved these changes
Jul 12, 2026
miguel-heygen
left a comment
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Re-reviewed current head and verified the addressed feedback and required behavior. Approval is for this exact head; Graphite mergeability may still be pending.
What: ImageThumbnail (+tests) and thumbnailUtils (+tests) — frame decode with SVG/AVIF format fallbacks and rounded-corner clipping — plus VideoThumbnail updates. Why: the decode layer for timeline clip thumbnails, ahead of the visual refresh that renders them. How: new modules + one modified file; purely presentational. Test plan: bunx vitest run on both test files; tsc --noEmit; fallow audit clean.
miguel-heygen
force-pushed
the
studio-dnd/pr22-app-shell-swap
branch
from
6e37e12 to
c0f0540
Compare
miguel-heygen
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
fe4be51 to
c8a0591
Compare
This was referenced Jul 12, 2026
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ImageThumbnail (+tests) and thumbnailUtils (+tests) — frame decode with SVG/AVIF format fallbacks and rounded-corner clipping — plus VideoThumbnail updates.
Why
the decode layer for timeline clip thumbnails, ahead of the visual refresh that renders them.
How
new modules + one modified file; purely presentational.
Test plan
bunx vitest run on both test files; tsc --noEmit; fallow audit clean.
Stack position 23/25 — studio NLE overhaul (CapCut-parity timeline + canvas). Graphite manages bases; merge from #2192 upward. Temporary
TEMP(studio-dnd)fallow entries (unwired-component windows) are all removed by #2213 (app-shell swap), whose tree is byte-identical to the fully-verified integration branch.