feat(studio): timeline visual refresh#2215
Merged
miguel-heygen merged 1 commit intoJul 12, 2026
Merged
Conversation
This was referenced Jul 11, 2026
Collaborator
Author
This was referenced Jul 11, 2026
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
c6864b7 to
e2986a7
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
2 times, most recently
from
8a91e44 to
7808aec
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
e2986a7 to
330bc77
Compare
miga-heygen
reviewed
Jul 11, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed as part of the 25-PR NLE overhaul stack. Full stack review on #2205 (the keystone). No blockers on this PR. — Miga
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
2906bdf to
6d3c7ee
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
ff8f3bf to
47e2df7
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
6d3c7ee to
67e76f2
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
47e2df7 to
51e0240
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
67e76f2 to
4db56fc
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
3183a29 to
a3a369c
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
4db56fc to
116a67c
Compare
miguel-heygen
approved these changes
Jul 11, 2026
miguel-heygen
left a comment
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Final rebase review: current head inspected, latest required checks pass, no unresolved blocking findings. Approving; stack order/invariants remain as specified.
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
a3a369c to
31fe1ba
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
116a67c to
0fd092c
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
31fe1ba to
905cea9
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
0fd092c to
8201043
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
905cea9 to
c26389a
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
8201043 to
d8bc202
Compare
ukimsanov
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
c26389a to
fe4be51
Compare
ukimsanov
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
d8bc202 to
a969043
Compare
miguel-heygen
approved these changes
Jul 12, 2026
miguel-heygen
left a comment
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Re-audit current head a969043: required checks pass; no new actionable threads. Approving current head.
miguel-heygen
approved these changes
Jul 12, 2026
miguel-heygen
left a comment
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Re-reviewed current head and verified the addressed feedback and required behavior. Approval is for this exact head; Graphite mergeability may still be pending.
What: visual pass on the timeline chrome — ruler, playhead, clip styling (now rendering the thumbnail modules), player controls, timeline theme and studio.css. Why: purely presentational; no timing or model changes. How: modified files only; consumes the thumbnail modules PR. Test plan: tsc --noEmit; bunx vitest run (suite unchanged); fallow audit clean.
miguel-heygen
force-pushed
the
studio-dnd/pr23-clip-thumbnails
branch
from
fe4be51 to
c8a0591
Compare
miguel-heygen
force-pushed
the
studio-dnd/pr24-timeline-visual-refresh
branch
from
a969043 to
f3186e1
Compare
This was referenced Jul 12, 2026
This was referenced Jul 12, 2026
miguel-heygen
merged commit d4fba3c
into
studio-dnd/pr23-clip-thumbnails
16 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
visual pass on the timeline chrome — ruler, playhead, clip styling (now rendering the thumbnail modules), player controls, timeline theme and studio.css.
Why
mostly presentational, with four behavioral pieces a reviewer should know about (review credit: Rames): a persisted
timeDisplayModepreference in the player store, a frame-mode ruler branch inTimelineRuler, clip cursor semantics simplified todefaultat rest, and the.timeline-clip.is-audiotint class. No timing/model changes.How
modified files only; consumes the thumbnail modules PR.
Test plan
tsc --noEmit; bunx vitest run (suite unchanged); fallow audit clean.
Stack position 24/25 — studio NLE overhaul (CapCut-parity timeline + canvas). Graphite manages bases; merge from #2192 upward. Temporary
TEMP(studio-dnd)fallow entries (unwired-component windows) are all removed by #2213 (app-shell swap), whose tree is byte-identical to the fully-verified integration branch.