fix(build): unbreak experimental feature compile (esaxx-rs)#326
Closed
mohabbis wants to merge 1 commit into
Closed
fix(build): unbreak experimental feature compile (esaxx-rs)#326mohabbis wants to merge 1 commit into
mohabbis wants to merge 1 commit into
Conversation
tokenizers' default esaxx_fast feature compiles esaxx-rs via clang/c++, which fails on Linux VMs where /usr/bin/c++ is clang selecting GCC 14 without libstdc++-14-dev (`cstdint` not found). Keep progressbar+onig only — local_llm only needs load/encode. Document the VM workaround. Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--features experimentalfailed on Linux when clang used GCC 14 libstdc++ paths but only libstdc++-13 headers were installed (esaxx-rs/<cstdint>).Disable
tokenizersesaxx_fast(keep pure-Rust esaxx) so experimental builds without a C++ toolchain mismatch. Document VMCXX=g++fallback in AGENTS.md.Test plan
cargo check --features experimental --all-targetscargo clippy --features experimental --all-targets -- -D warnings