chore(iscript): Fix python dependency list - #1495
Merged
Merged
Conversation
hneiva
commented
Jul 27, 2026
hneiva
commented
Contributor
- Add requests (was being imported by another package, but used explicitly)
- Removes aiohttp, arrow, macholib, taskcluster (unused)
- Add requests (was being imported by another package, but used explicitly) - Removes aiohttp, arrow, macholib, taskcluster (unused)
bhearsum
reviewed
Jul 28, 2026
| "arrow>=1.0", | ||
| "attrs", | ||
| "macholib", | ||
| "mozbuild", |
Contributor
There was a problem hiding this comment.
Are you sure mozbuild is still needed here? I don't see any direct usage of it, nor any indirect usage of it through scriptworker_client.
Contributor
Author
There was a problem hiding this comment.
There's a from mozpack import mozjar in autograph.py
And mozpack is provided by mozbuild 🤷
Contributor
There was a problem hiding this comment.
Oh; I was expecting the mozbuild imports to be...well...prefixed by mozbuild :(
bhearsum
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.