Skip to content

chore(iscript): Fix python dependency list #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hneiva merged 1 commit into from
Jul 28, 2026
+7 −13
Merged

chore(iscript): Fix python dependency list #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions iscript/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ classifiers = [
"Programming Language :: Python :: 3.11",
]
dependencies = [
"aiohttp",
"arrow>=1.0",
"attrs",
"macholib",
"mozbuild",

@bhearsum bhearsum Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure mozbuild is still needed here? I don't see any direct usage of it, nor any indirect usage of it through scriptworker_client.

@hneiva hneiva Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a from mozpack import mozjar in autograph.py
And mozpack is provided by mozbuild 🤷

@bhearsum bhearsum Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh; I was expecting the mozbuild imports to be...well...prefixed by mozbuild :(

"pexpect",
"requests",
"requests-hawk",
"scriptworker-client",
"taskcluster",
# for mozbuild - remove after the following bug is fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1831648
# mozbuild imports these but doesn't declare them; upstream removed its
# setup.py entirely (https://bugzilla.mozilla.org/show_bug.cgi?id=1831648)
# rather than fix the metadata, so these must stay declared here for as
# long as we vendor mozbuild.
"packaging",
"six",
]
Expand Down
10 changes: 2 additions & 8 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.