feat: make astQuery a first-class feature#86
Open
isaacs wants to merge 1 commit into
Open
Conversation
This is the cleanest way to do certain things that cannot be reached by name alone. However, it's brittle to rely on a feature, even a stable one, which is not documented or tested. So, treat it as a first-class feature.
timfish
approved these changes
Jul 1, 2026
jsumners-nr
reviewed
Jul 1, 2026
| When present, `astQuery` chooses the nodes to instrument and | ||
| takes precedence over `functionQuery`'s matching fields; | ||
| `functionQuery` then only supplies behaviour (`kind`, `index`, | ||
| `callbackIndex`, `mutableResult`) and may be omitted (it defaults |
Contributor
There was a problem hiding this comment.
mutableResult is no longer a thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: based on #85, land that first
This is the cleanest way to do certain things that cannot be reached by name alone. However, it's brittle to rely on a feature, even a stable one, which is not documented or tested. So, treat it as a first-class feature.