feat: add nodeSelector support for scheduled task scopes#196
Merged
Conversation
geisbruch
approved these changes
Jul 8, 2026
geisbruch
added a commit
that referenced
this pull request
Jul 9, 2026
Hotfix: revert PR #196 (scheduled task nodeSelector)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
nodeSelectorsupport to the scheduled task (CronJob) deployment template, closing a gap with the k8s deployment template which already supported it.tolerationswas already supported in both templates; onlynodeSelectorwas missing from scheduled tasks.Changes
scheduled_task/deployment/templates/deployment.yaml.tpl: render anodeSelectorblock fromk8s_modifiers.deployment.nodeselector, mirroring the existingtolerationsblock and sharing the same{{- if $deployment }}guard.CHANGELOG.md: entry under[Unreleased].Notes
nodeselector(the platform's modifier name), rendered to the k8s-canonicalnodeSelector:key — same convention as the k8s deployment template.indent 10(not8) because the CronJob nests the pod spec underjobTemplate → spec → template → spec, matching the siblingtolerationsblock.values.yamlchange needed —k8s_modifiersare injected by the platform at render time.Test plan
deployment.nodeselectormodifier and confirm the CronJob pod template rendersnodeSelector.