Upgrade Go version to 1.26.5 and update dependencies#1804
Upgrade Go version to 1.26.5 and update dependencies#1804NewEraCracker wants to merge 2 commits into
Conversation
- Update Go version requirement from 1.25.3 to 1.26.5 in GOVERSION and go.mod - Update toolchain specification to go1.26.5 in go.mod - Update Psiphon library dependencies to their latest versions: - github.com/Psiphon-Labs/bolt to v0.0.0-20260624144735-04fba30caf38 - github.com/Psiphon-Labs/psiphon-tls to v0.0.0-20260612202619-4944f00a8304 - github.com/Psiphon-Labs/utls to v1.1.1-0.20260602140907-e3b959a8340b - Simplify build constraints in psiphon feature flags by removing go1.25 checks, as minimum Go version is now 1.26
|
It's my first PR here, in fact it is my first shot at Go. I copied some stuff from: As I have no idea how to generate these automatically. I leave the userauth bug to those who may know how to solve it. the PR focus solely on fixing psiphon compatibility issues. Edit: If desired, the developer team should have to look into upgrading the userauth static lib to Go 1.26. The issue is local as well. My two cents. Thank you. |
|
Hello @NewEraCracker, thanks for your PR. We do not aim to support go1.26 at the moment. As for psiphon: we sunset psiphon support in |
|
Hi, It is imperative to apply Go 1.26 as these new psiphon dependencies depend on it. Otherwise close this without merging.
I am not so sure, the CLI of v3.29.0 and v3.29.1 still have psiphon supported out of the box for the circumvention test. My two cents. Thank you. |
|
When you'd really like to stick with go1.25 then ignore this PR, otherwise if you build with go1.25 nuking the protections, then the OONI Probe CLI will explode, even on basic commands. |
Sorry, I see what you mean. It seems psiphon skipped go1.25 altogether which makes things a little tough for us. it's not our immediate intent to support go1.26 at the moment. However, let us reflect on this. With go1.27 planned for next month, we were aiming to switch to go1.26 in the next release anyway. Let me evaluate the effort it might require before the release. If need be, we will make switch to go1.26 in this release itself. As part of this PR, could you also update the GOVERSION file to |
DecFox
left a comment
There was a problem hiding this comment.
Just to ensure this builds well when go1.27 releases.
|
Hey @NewEraCracker, I have gone through the changes required for us to support
If you want to refer to what it takes to upgrade the go version, we have some documentation on the release process we follow here: https://github.com/ooni/probe-cli/blob/master/docs/releasing.md. One other thing: this is a bit time-sensitive since we're hoping to get a release out soon. If you think you might not have time to get to these changes in the near term, I'm happy to take this PR over and push it across the finish line. I don't want to step on your work though, so only if that would be helpful. |
|
Hello, Indeed, I may not have time to get to these changes in the near term. I'd appreciate if you could take over this PR and take it to the finish line. Thank you very much. |
Checklist
Description